Good job! Few of my comments: assert_exists - should be private in watir-webdriver i think browser - what is the point of that instance method? cell/cells - if i'm not mistaken then these methods were available for Table in webdriver. There was some logic behind that. Same goes with row/rows. element(s)_by_xpath - these methods should be private in watir-webdriver too as they are now for watir 3 field_set/field_sets - these methods came with watir 3 and are just there for aliases. No need to deprecate these i think, but it would be nice if watir webdriver would make these aliases too. input_element(s) - aren't these methods being generated after Element is subclassed by InputElement? If that's the case then i would delete these methods and not make them private. Same goes to table_cell(s), table_row(s) and table_section(s).
Also added a few inline comments below. On Sun, Feb 12, 2012 at 11:18 PM, Hugh McGowan <[email protected]>wrote: > * Watir automatically creates methods when subclassed from Element > which is convenient but adds methods for things that shouldn't be in the > API (for example #radio_check_common). Find a better way to handle this to > clean up the exposed API > I have been planning to revise that part too and make all methods creation more explicit. So if you don't have anything against that then i'd take that task for myself. Not sure when i will deal with it though exactly. It seems to me that before we release 3.0 we need to > * make the watirspec tests that fail for implemented features pass (fix > things like tables and xpath that we've implemented, don't worry about > unimplemented features) > I'm not 100% sure that this should be a release blocker since all these xpath things are failing with < 3 version too. Thanks! > Hugh > Jarmo
_______________________________________________ Wtr-development mailing list [email protected] http://rubyforge.org/mailman/listinfo/wtr-development
