So far I think you can move the whole wait spec to watirspec and bump it
watir-webdriver. Then close this PR and open new one with full wait
implementation and watirspec update.
At least that's what I would have done ;)
Cheers,
Alex
> On 30 íîÿá. 2013 ã., at 0:25, Justin Ko <[email protected]> wrote:
>
> I agree that moving the specs to watirspec would be better. What would the
> process be for that?
>
> Would I:
>
> Create a pull request to watirspec to add the wait_spec and
> Create a pull request to watir-webdriver to remove the duplicated specs and
> Update this pull request to remove the duplicated specs
> For the wait_spec, should I just move the tests that describe
> "Watir.default_timeout"? There seem to be other wait related specs in
> watir-webdriver that I would think apply to watir-classic as well - for
> example #wait_until_present. Should I move those as well or perhaps leave
> that for a different pull request?
>
> —
> Reply to this email directly or view it on GitHub.
---
Reply to this email directly or view it on GitHub:
https://github.com/watir/watir-classic/pull/66#issuecomment-29530719
_______________________________________________
Wtr-development mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/wtr-development
