Paul Slootman <[EMAIL PROTECTED]> wrote:
> A couple of problems:
>
> - There is a blank line before the .TH line in wwwoffled.man which
> causes (at least) the debian man program to spew out a blank
> page at the beginning.
That file has been like that for ~20 months, I am surprised that
nobody has noticed it before.
> - Due to an oversight, I didn't have a DontCompress section in my
> config file (I hadn't run the upgrade-config.pl script yet),
> and the wwwoffles processes that were forked died of SIGSEGV in
> NotCompressed() when DontCompressExt->nitems was accessed
> (DontCompressExt is NULL at that point).
I guess this shows that most people must use the upgrade-config.pl
script or I imagine that more people would have reported this bug.
> IMHO an application should never core dump if the config file isn't
> correct (I believe a typo in "DontCompress" will have the same
> result), and it's not that straightforward to figure out what the
> matter is... In fact, I believe an app should _never_ core dump,
> period.
Any typo in DontCompress will be recognised.
I quite agree with the _never_ core dumping idea.
> Perhaps the result of reading in the config file should be
> sanity-checked before proceeding?
If you look at the other options that use ConfigItemFoo->nitems they
are all protected by testing that ConfigItemFoo is not-NULL. By some
oversight I missed it when I added these two.
> - Running convert-cache (OK, I know, not needed when upgrading from
> 2.6[ab] :-) I get the following error:
>
> convert-cache[10235] Fatal: Configuration file error at configfile.c:98; Expecting
>a URL, got '/local/dontget/replacement.gif'.
>
> There are three places where that string occurs in the config file,
> namely replacement-dontget-image, replacement-webbug-image (in ModifyHTML)
> and replacement (in DontGet).
That serves me right for trying to be too clever. To reduce the size
of the executables for the secondary programs (convert-cache etc.) I
try not to link in all the WWWOFFLE program code. Doing that does
cause this bug to occur for some URLs.
All of these bugs will be fixed in the next version.
--
Andrew.
----------------------------------------------------------------------
Andrew M. Bishop [EMAIL PROTECTED]
http://www.gedanken.demon.co.uk/
WWWOFFLE users page:
http://www.gedanken.demon.co.uk/wwwoffle/version-2.6/user.html
