"Paul A. Rombouts" <[EMAIL PROTECTED]> writes:
> Paul Slootman wrote:
> >
> > Now, when trying it out, I find that it doesn't request compressed data,
> > despite the "request-compressed-data = yes" option in the conf file.
> > Yes, it's compiled with zlib support:
<snip list of headers of request>
> > The Accept-Encoding: line is not there...
> In the file parse.c I found the following lines of code which, I think, explain
> what is going on:
> The function ModifyRequest is called at lines 290 and 1485 of wwwoffles.c.
> So it seems that the Accept-Encoding header line is first deleted from the
> request.
> But later, at line 1593, if correctly configured, WWWOFFLE adds its own version
> back on:
> The trouble is, that the request is written to the remote server at line 1496.
> So the addition of the Accept-Encoding header line comes too late to do any
> good.
This is a correct analysis of the problem. I changed the way that the
request for compression was handled so that it was in wwwoffles.c and
not in http.c. This means that I made the mistake of adding the
header too late.
> I rearranged the code in wwwoffles.c a bit so the Accept-Encoding line is added
> at what I think is the right moment. I've attached a patch file to this message
> so you can try this for yourself.
The patch file that you attached should work, it is almost identical
to the change that I have made to the main source code.
It looks like my testing for version 2.7 wasn't complete enough.
Perhaps I should have given the beta testers more time before
releasing the final version.
--
Andrew.
----------------------------------------------------------------------
Andrew M. Bishop [EMAIL PROTECTED]
http://www.gedanken.demon.co.uk/
WWWOFFLE users page:
http://www.gedanken.demon.co.uk/wwwoffle/version-2.7/user.html
