Re: [WWWOFFLE-Users] Cookies: is the fix on setting more than one cookie per page done?

[Marc Boucher]

At 07:56 09/09/2002 +0200, Miernik wrote:
>[...]
>In version 2.7c it was:
>The fix for the cookies with incompatible browsers (listed above) didn't
>work totally and may now cause WWWOFFLE to crash when combining cookies or
>corrupt the cookie data.
>
>There is no evidence how it is in later versions.
>
>Are there any problems with cookies now?
>Are there any pages, where you have to use the DontCache section because
>of cookies, because otherwise login or something won't work?

The fix in 2.7d didn't work. At least for some sites (yahoo/eGroups,
sometimes NY-Times). I've made a patch for this version.
It was included in 2.7e, but with errors. And the fix still doesn't work.

Here is a patch for 2.7e.
I've waited several days before sending it to the list.


-- 
Marc

--- headbody.c  Sat Aug 10 15:48:25 2002
+++ headbody.c  Fri Sep  6 00:04:03 2002
@@ -548,8 +548,8 @@
 
  for(i=0;i<head->n;i++)
    {
-    strcpy(p,head->key[i]); p+=strlen(head->key[i]);
-    strcpy(p,": ");         p+=2;
+//    strcpy(p,head->key[i]); p+=strlen(head->key[i]);
+//    strcpy(p,": ");         p+=2;
 
     /*
        Cookies are a big problem here since none of the browsers handle them
@@ -580,6 +580,8 @@
              p=str+offset;
             }
 
+          strcpy(p,head->key[i]); p+=strlen(head->key[i]);
+          strcpy(p,": ");         p+=2;
           while(*lp && *lp!=',')
              *p++=*lp++;
           *p=0;
@@ -595,16 +597,20 @@
 
           while(isspace(*(p-1)))
              *--p=0;
+          strcpy(p,"\r\n");       p+=2;
          }
 
        free(list);
       }
     else
       {
+       strcpy(p,head->key[i]); p+=strlen(head->key[i]);
+       strcpy(p,": ");         p+=2;
        strcpy(p,head->val[i]); p+=strlen(head->val[i]);
+       strcpy(p,"\r\n");       p+=2;
       }
 
-    strcpy(p,"\r\n");       p+=2;
+//    strcpy(p,"\r\n");       p+=2;
    }
 
  strcpy(p,"\r\n");