On 31/05/11 15.06, Mark Dootson wrote: <snip>
I think that this means wxAuiNotebook is broken in 2.8.11 / 2.8.12 so will propose a change on wxWidgets trac. Even if this change is accepted, wxWidgets 2.8.13 will be some way off. Should we incorporate a patch into Alien::wxWidgets ? I think as a general rule, patching wxWidgets other than to allow compilation is a bad idea.
I agree in general. In this case it is less of an issue because it is a Windows-only problem/patch (and on Windows you don't have to account for unpatched system wxWidgets(.
Patching to fix this particular issue on 2.8.12 also has problems - similar changes are in the 2.9/trunk branch so it is a change that needs to be worked with eventually - however, new Freeze and Thaw methods are implemented in the wxAUI objects in 2.9/trunk which I'd assume provide a way of working with this change. But - it seems wrong to have the Padre folks struggling for a workaround to a change in wxWidgets that I'm fairly sure needs removing in the 2.8 branch. Everyone's thoughts - to patch or not to patch ? Final decision would be Mattia's of course as it is not a regular step to patch wxWidgets.
I think that it's OK to patch if we apply the same patch that will go into 2.8.13.
Regards, Mattia
