Fri May 29 13:51:31 2015: Request 103235 was acted upon. Transaction: Correspondence added by ro...@metsci.com Queue: Wx Subject: RE: [rt.cpan.org #103235] Support for TreeListCtrl->EnsureVisible(item) Broken in: (no value) Severity: (no value) Owner: Nobody Requestors: ro...@metsci.com Status: open Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=103235 >
I may misunderstand, but I don't think the corresponding change is in TreeCtrl.xs. EnsureVisible is already defined there. The missing functionality is specifically on TreeListCtrl (not TreeCtrl), which as best I can figure out is only specified in treelist.h, and is not generated from the XS. Can you elaborate on any problems? I would be willing to spend some time resolving. I'm using this functionality and would like to see it checked in. I get it to build fine on both Fedora 22 and Win7. ________________________________ From: Steve Cookson - gmail [steveco.1...@gmail.com] Sent: Sunday, April 12, 2015 10:30 AM To: bug...@rt.cpan.org; wxperl-users@perl.org; Rowe, Thomas Subject: Re: [rt.cpan.org #103235] Support for TreeListCtrl->EnsureVisible(item) Hi Robert, The corresponding change in wxPerl would be to the file: TreeCtrl.xs in the wxPerl/XS directory. The syntax looks a little painful, maybe because of the history of wxTreeCtrl, but if you took the existing void function IsExpanded and copied it to create this: #if WXPERL_W_VERSION_GE(3, 0, 2 ) void wxTreeCtrl::EnsureVisible( item ) wxTreeItemId* item C_ARGS: *item #endif then did a sudo make install from the wxPerl directory, I imagine it would work. I did add the patch you sent to my wxWidgets install and got a clean compile, but I'm afraid that for other reasons I don't get a clean compile on wxPerl! So I'm sorry that I can't check it for you. If it does work, I'm sure Mark would appreciate a patch. Good luck, Steve. On 31/03/15 16:29, Rowe, Thomas via RT wrote: Tue Mar 31 15:29:42 2015: Request 103235 was acted upon. Transaction: Ticket created by ro...@metsci.com<mailto:ro...@metsci.com> Queue: Wx Subject: Support for TreeListCtrl->EnsureVisible(item) Broken in: (no value) Severity: (no value) Owner: Nobody Requestors: ro...@metsci.com<mailto:ro...@metsci.com> Status: new Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=103235 > Hi, I have a Wx pull request pending that adds support for wxTreeListCtrl::EnsureVisible. https://github.com/wxWidgets/wxWidgets/pull/22 Perhaps it's premature to request the corresponding wxperl change, but I'm using it locally and hope to find it incorporated upstream in a future release. Thanks. diff --git a/interface/wx/treelist.h b/interface/wx/treelist.h index 96678c6..d8cb794 100644 --- a/interface/wx/treelist.h +++ b/interface/wx/treelist.h @@ -211,6 +211,8 @@ wxTreeListCtrl::GetImageList() bool IsExpanded(wxTreeListItem item) const; + void EnsureVisible(wxTreeListItem item); + wxTreeListItem GetSelection() const; %{