At 2014-07-02 23:54:17,"Steve Borho" <st...@borho.org> wrote: >On Wed, Jul 2, 2014 at 10:35 AM, chen <chenm...@163.com> wrote: >> We can reuse [0] everytime, we alloc at least 1 TLD in Encoder::create() > >Not if another frame encoder or frame filter can be using it at the >same time; and definitely not if the Encoder's TLD array is static. >This is why the FrameEncoder has it's own m_tld instance, for --no-wpp >operation. > >There is a 1::1 correlation between FrameEncoder and FrameFilter, so >it would be appropriate for the FrameFilter to use the FrameEncoder's >reserved m_tld if the FrameFilter functions are not using a worker >thread. > >-- >Steve Borho >_______________________________________________ you are right, it is my fault. I see the code below, I assume we just one thread in pool, but I forgot FrameParallelism have another thread, please ignore my patch before. // Trim the thread pool if WPP is disabled if (!p->bEnableWavefront) p->poolNumThreads = 1;
_______________________________________________ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel