On Tue, Dec 18, 2018 at 10:13 PM <x265-devel-requ...@videolan.org> wrote:
> Send x265-devel mailing list submissions to > x265-devel@videolan.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://mailman.videolan.org/listinfo/x265-devel > or, via email, send a message with subject or body 'help' to > x265-devel-requ...@videolan.org > > You can reach the person managing the list at > x265-devel-ow...@videolan.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of x265-devel digest..." > > > Today's Topics: > > 1. [PATCH] x265 - Cutree Offset Reuse: Restricted to analysis > reuse level 10 (Akil) > 2. Re: [PATCH 1 of 2] Add support for Dolby Vision profile 8.1 > (Vittorio Giovara) > 3. Re: [PATCH 1 of 2] Add support for Dolby Vision profile 8.1 > (Vittorio Giovara) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Tue, 18 Dec 2018 16:57:50 +0530 > From: Akil <a...@multicorewareinc.com> > To: x265-devel@videolan.org > Subject: [x265] [PATCH] x265 - Cutree Offset Reuse: Restricted to > analysis reuse level 10 > Message-ID: > <CAMGzPfwO=mz=uFLOBA-ydKnF7mpfEikn+4guRDhNfxFgz= > s...@mail.gmail.com> > Content-Type: text/plain; charset="utf-8" > > # HG changeset patch > # User Akil Ayyappan<a...@multicorewareinc.com> > # Date 1545126758 -19800 > # Tue Dec 18 15:22:38 2018 +0530 > # Node ID da15824d3d7753a6372afdb7f438e553046f084e > # Parent 81373aab81dfe2e31a5ef353b1073d8bf1e22502 > Cutree Offset Reuse: Restricted to analysis reuse level 10 > > diff -r 81373aab81df -r da15824d3d77 source/encoder/encoder.cpp > --- a/source/encoder/encoder.cpp Thu Dec 13 10:55:15 2018 +0530 > +++ b/source/encoder/encoder.cpp Tue Dec 18 15:22:38 2018 +0530 > @@ -2755,6 +2755,12 @@ > x265_log(m_param, X265_LOG_WARNING, "CRF min must be less than > CRF\n"); > p->rc.rfConstantMin = 0; > } > + > + if ((p->analysisLoad || p->analysisSave) && p->rc.cuTree && > p->analysisReuseLevel < 10) > + { > + x265_log(p, X265_LOG_WARNING, "cu-tree works only with analysis > reuse level 10, Disabling cu-tree\n"); > + p->rc.cuTree = 0; > + } > > if ((p->analysisLoad || p->analysisSave) && > (p->bDistributeModeAnalysis || p->bDistributeMotionEstimation)) > { > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: < > http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/86047179/attachment-0001.html > > > -------------- next part -------------- > A non-text attachment was scrubbed... > Name: Cutree offset reuse - bug fix.patch > Type: application/octet-stream > Size: 1006 bytes > Desc: not available > URL: < > http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/86047179/attachment-0001.obj > > > > ------------------------------ > > Message: 2 > Date: Tue, 18 Dec 2018 11:42:02 -0500 > From: Vittorio Giovara <vittorio.giov...@gmail.com> > To: Development for x265 <x265-devel@videolan.org> > Subject: Re: [x265] [PATCH 1 of 2] Add support for Dolby Vision > profile 8.1 > Message-ID: > < > cablwns_wc+y+01uwugax_omxscql+1s4wknxqehr-9b_sbc...@mail.gmail.com> > Content-Type: text/plain; charset="utf-8" > > On Tue, Dec 18, 2018 at 3:07 AM Kirithika Kalirathnam < > kirith...@multicorewareinc.com> wrote: > > > # HG changeset patch > > # User kirithika <kirith...@multicorewareinc.com> > > # Date 1544426306 -19800 > > # Mon Dec 10 12:48:26 2018 +0530 > > # Node ID 827668cf88a85f8d14b8943c53e3f4c87196e96d > > # Parent 81373aab81dfe2e31a5ef353b1073d8bf1e22502 > > Add support for Dolby Vision profile 8.1 > > > > diff -r 81373aab81df -r 827668cf88a8 doc/reST/cli.rst > > --- a/doc/reST/cli.rst Thu Dec 13 10:55:15 2018 +0530 > > +++ b/doc/reST/cli.rst Mon Dec 10 12:48:26 2018 +0530 > > @@ -2214,7 +2214,7 @@ > > The value is specified as a float or as an integer with the profile > > times 10, > > for example profile 5 is specified as "5" or "5.0" or "50". > > > > - Currently only profile 5 enabled, Default 0 (disabled) > > + Currently only profile 5 and profile 8.1 enabled , Default 0 > > (disabled) > > > > .. option:: --dolby-vision-rpu <filename> > > > > diff -r 81373aab81df -r 827668cf88a8 source/common/param.cpp > > --- a/source/common/param.cpp Thu Dec 13 10:55:15 2018 +0530 > > +++ b/source/common/param.cpp Mon Dec 10 12:48:26 2018 +0530 > > @@ -1418,14 +1418,17 @@ > > "Invalid refine-intra value, refine-intra levels 0 to 3 > > supported"); > > CHECK(param->maxAUSizeFactor < 0.5 || param->maxAUSizeFactor > 1.0, > > "Supported factor for controlling max AU size is from 0.5 to > 1"); > > - CHECK((param->dolbyProfile != 0) && (param->dolbyProfile != 50), > > - "Unsupported Dolby Vision profile, only profile 5 enabled"); > > - if (param->dolbyProfile == 50) > > + CHECK((param->dolbyProfile != 0) && (param->dolbyProfile != 50) && > > (param->dolbyProfile != 81), > > + "Unsupported Dolby Vision profile, only profile 5 and profile > 8.1 > > enabled"); > > + if (param->dolbyProfile) > > { > > - CHECK((param->rc.vbvMaxBitrate < 0 && param->rc.vbvBufferSize < > > 0), "Dolby Vision requires VBV settings to enable HRD.\n"); > > - CHECK((param->sourceWidth > 3840 || param->sourceHeight > 2160), > > "Maximum supported resolution for Dolby Vision profile - 5 is 4k UHD\n"); > > - CHECK((param->internalBitDepth != 10), "Dolby Vision profile - 5 > > is Main10 only\n"); > > - CHECK((param->internalCsp != X265_CSP_I420), "Dolby Vision > > profile - 5 requires YCbCr 4:2:0 color space\n"); > > + CHECK((param->rc.vbvMaxBitrate <= 0 && param->rc.vbvBufferSize > <= > > 0), "Dolby Vision requires VBV settings to enable HRD.\n"); > > > > This is still wrong, the condition should be (param->rc.vbvMaxBitrate <= 0 > && param->rc.vbvBufferSize <= 0) since you need both values set to > something in order to have a working VBV. I mentioned this in a previous > review but it got ignored and the wrong version got pushed... > > Yes,it's a wrong check.I shall fix this check and resend the patch. > > > + CHECK((param->sourceWidth > 3840 || param->sourceHeight > 2160), > > "Maximum supported resolution for Dolby Vision profile - 5 and profile - > > 8.1 is 4k UHD\n"); > > > > nit: double space before "- 8.1" > also this constraint is a bit strange, what about 4k dci? seems odd that it > is not supported... > I shall fix the nit in the updated version of the patch.Regarding 4K dci, it is not supported by Dolby Vision profiles 5,8.1 and 8.2. The maximum resolution supported for Dolby Vision encodes is 4K-UHD. > > + CHECK((param->internalBitDepth != 10), "Dolby Vision profile - 5 > > and profile - 8.1 is Main10 only\n"); > > + CHECK((param->internalCsp != X265_CSP_I420), "Dolby Vision > > profile - 5 and profile - 8.1 requires YCbCr 4:2:0 color space\n"); > > + > > + if (param->dolbyProfile == 81) > > + CHECK(!(param->masteringDisplayColorVolume), "Dolby Vision > > profile - 8.1 requires Mastering display color volume information\n"); > > } > > #if !X86_64 > > > -- > Vittorio > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: < > http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/ec3c5769/attachment-0001.html > > > > ------------------------------ > > Message: 3 > Date: Tue, 18 Dec 2018 11:43:00 -0500 > From: Vittorio Giovara <vittorio.giov...@gmail.com> > To: Development for x265 <x265-devel@videolan.org> > Subject: Re: [x265] [PATCH 1 of 2] Add support for Dolby Vision > profile 8.1 > Message-ID: > < > cablwns-mfr0d2+u-0i+r2rkvfdyojua07840mbefdy89p81...@mail.gmail.com> > Content-Type: text/plain; charset="utf-8" > > On Tue, Dec 18, 2018 at 11:42 AM Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > > > > > > > On Tue, Dec 18, 2018 at 3:07 AM Kirithika Kalirathnam < > > kirith...@multicorewareinc.com> wrote: > > > >> # HG changeset patch > >> # User kirithika <kirith...@multicorewareinc.com> > >> # Date 1544426306 -19800 > >> # Mon Dec 10 12:48:26 2018 +0530 > >> # Node ID 827668cf88a85f8d14b8943c53e3f4c87196e96d > >> # Parent 81373aab81dfe2e31a5ef353b1073d8bf1e22502 > >> Add support for Dolby Vision profile 8.1 > >> > >> diff -r 81373aab81df -r 827668cf88a8 doc/reST/cli.rst > >> --- a/doc/reST/cli.rst Thu Dec 13 10:55:15 2018 +0530 > >> +++ b/doc/reST/cli.rst Mon Dec 10 12:48:26 2018 +0530 > >> @@ -2214,7 +2214,7 @@ > >> The value is specified as a float or as an integer with the profile > >> times 10, > >> for example profile 5 is specified as "5" or "5.0" or "50". > >> > >> - Currently only profile 5 enabled, Default 0 (disabled) > >> + Currently only profile 5 and profile 8.1 enabled , Default 0 > >> (disabled) > >> > >> .. option:: --dolby-vision-rpu <filename> > >> > >> diff -r 81373aab81df -r 827668cf88a8 source/common/param.cpp > >> --- a/source/common/param.cpp Thu Dec 13 10:55:15 2018 +0530 > >> +++ b/source/common/param.cpp Mon Dec 10 12:48:26 2018 +0530 > >> @@ -1418,14 +1418,17 @@ > >> "Invalid refine-intra value, refine-intra levels 0 to 3 > >> supported"); > >> CHECK(param->maxAUSizeFactor < 0.5 || param->maxAUSizeFactor > 1.0, > >> "Supported factor for controlling max AU size is from 0.5 to > 1"); > >> - CHECK((param->dolbyProfile != 0) && (param->dolbyProfile != 50), > >> - "Unsupported Dolby Vision profile, only profile 5 enabled"); > >> - if (param->dolbyProfile == 50) > >> + CHECK((param->dolbyProfile != 0) && (param->dolbyProfile != 50) && > >> (param->dolbyProfile != 81), > >> + "Unsupported Dolby Vision profile, only profile 5 and profile > >> 8.1 enabled"); > >> + if (param->dolbyProfile) > >> { > >> - CHECK((param->rc.vbvMaxBitrate < 0 && param->rc.vbvBufferSize < > >> 0), "Dolby Vision requires VBV settings to enable HRD.\n"); > >> - CHECK((param->sourceWidth > 3840 || param->sourceHeight > > 2160), > >> "Maximum supported resolution for Dolby Vision profile - 5 is 4k > UHD\n"); > >> - CHECK((param->internalBitDepth != 10), "Dolby Vision profile - > 5 > >> is Main10 only\n"); > >> - CHECK((param->internalCsp != X265_CSP_I420), "Dolby Vision > >> profile - 5 requires YCbCr 4:2:0 color space\n"); > >> + CHECK((param->rc.vbvMaxBitrate <= 0 && param->rc.vbvBufferSize > >> <= 0), "Dolby Vision requires VBV settings to enable HRD.\n"); > >> > > > > This is still wrong, the condition should be (param->rc.vbvMaxBitrate <= > 0 > > && param->rc.vbvBufferSize <= 0) > > > > copy paste fail, I meant to write "(param->rc.vbvMaxBitrate <= 0 || > param->rc.vbvBufferSize <= 0)" > > -- > Vittorio > -------------- next part -------------- > An HTML attachment was scrubbed... > URL: < > http://mailman.videolan.org/pipermail/x265-devel/attachments/20181218/4b371f42/attachment.html > > > > ------------------------------ > > Subject: Digest Footer > > _______________________________________________ > x265-devel mailing list > x265-devel@videolan.org > https://mailman.videolan.org/listinfo/x265-devel > > > ------------------------------ > > End of x265-devel Digest, Vol 67, Issue 15 > ****************************************** >
_______________________________________________ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
