Hi Hari,
Thank for the new patches. Just one comment, all of other looks good for me. In the FindNEON_DOTPROD.cmake, it just support Apple and Linux platform, I suggest keep compatible for Windows ARM platform future, so display error message other than assume *nux shell. Regards, Chen At 2024-07-30 23:44:16, "Hari Limaye" <hari.lim...@arm.com> wrote: >Hi, > >Pushing a brand new stack of all 8 patches in this patch-set, which >supersedes the previous set of patches. > >Many thanks, >Hari > >Hari Limaye (8): > AArch64: Optimise Neon assembly implementations of SAD > AArch64: Optimise Neon assembly implementations of SADxN > AArch64: Remove SVE2 SAD/SADxN primitives > AArch64: Clean up CMake feature detection > AArch64: Add Armv8.4 Neon DotProd feature detection > AArch64: Refactor setup of optimised assembly primitives > AArch64: Add Armv8.4 Neon DotProd implementations of SAD > AArch64: Add Armv8.4 Neon DotProd implementations of SADxN > > build/README.txt | 8 + > source/CMakeLists.txt | 89 ++- > source/cmake/FindNEON_DOTPROD.cmake | 21 + > source/common/CMakeLists.txt | 6 +- > source/common/aarch64/asm-primitives.cpp | 832 ++--------------------- > source/common/aarch64/fun-decls.h | 21 + > source/common/aarch64/sad-a-common.S | 514 -------------- > source/common/aarch64/sad-a-sve2.S | 511 -------------- > source/common/aarch64/sad-a.S | 511 +++++++++++++- > source/common/aarch64/sad-neon-dotprod.S | 330 +++++++++ > source/common/cpu.cpp | 19 +- > source/test/testbench.cpp | 3 +- > source/x265.h | 11 +- > 13 files changed, 990 insertions(+), 1886 deletions(-) > create mode 100644 source/cmake/FindNEON_DOTPROD.cmake > delete mode 100644 source/common/aarch64/sad-a-common.S > delete mode 100644 source/common/aarch64/sad-a-sve2.S > create mode 100644 source/common/aarch64/sad-neon-dotprod.S > >-- >2.42.1 > >_______________________________________________ >x265-devel mailing list >x265-devel@videolan.org >https://mailman.videolan.org/listinfo/x265-devel
_______________________________________________ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel
