Erwin,
Thanks a million for all your effort! You are the first 'external'
contributor to the XSLTC code, so congratualtions. I'll buy you a
pint if you come over to Dublin for the Apache conference later
this year...
I could not apply the diffs directly as some of the source code
has changed drastically since you made the diffs. I went through
the code by hand, had a through look at your changes, and
integrated them into our source tree. A few of your changes had
been made already, and a few bugs had already been handled by
other methods than those you've suggested, so I took the liberty
to make some minor adjustments:
o) I've already made some changes to our handling of <xsl:if>
and <xsl:when> to check if they wrap unsupported external
functions. I still added your fix to FunctionCall and the
BasisLibrary classes, with the minor modification of emitting
warning messages when calls to unsupported functions are
compiled into the translet.
o) Some of the illegal method names had already been changed
and now contain underscores instead of dollar-signs.
o) I've made some minor changes to the way you compiled
IFNE skip
GOTO_W far_away
instead of
IFEQ far_away
but most of your changes are exactly as they were in the diffs.
Some of these changes are very impressive, especially in the
Mode class, where the code can be very hard to understand.
o) Your changes to Include and Import were implemented as they
were in the difs
o) Some of your changes to the error/warning handling in the Parser
class is changed a lot. I don't want to include stack traces in
the error/warning messages.
All that remains now is to run a full system test before I do the
final commit of the code changes. I will probably integrate your
fixes around 16:00 / 17:00 GMT today.
Thanks,
Morten
Erwin Bolwidt wrote:
>
> Hi Morten,
>
> This is the diff to the XSLTC source of the changes that I made to get
> docbook to work (after applying the changes that I sent to the docbook
> stylesheets)
>
> I sent a summary of the changes in the source in an e-mail a few days
> before the diff, do you have e-mail?
>
> Regards,
> Erwin
