I'll committ it as soon as I can -- sometime today.

Gary

[EMAIL PROTECTED] wrote:
> 
> > I'm leaning toward the second alternative since I think that non-ASCII
> > characters occur relatively infrequently (at least for me) and I hate to
> pay the
> > penalty for a multiply on every write.
> 
> Gary, I agree.
> 
> -scott
> 
> 
>                     Gary L Peskin
>                     <garyp@firste        To:     Scott Boag <[EMAIL PROTECTED]>
>                     ch.com>              cc:
>                                          Subject:     Bug 2639
>                     07/24/2001
>                     02:14 PM
> 
> 
> 
> Scott -
> 
> Can you please look at
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=2639
> I'd appreciate your comments before committing a fix.  Also, Joe
> suggested perhaps shifting the incoming length left 2 bits.  This would
> waste more buffer but possibly save time versus a multiply.
> 
> I do, however, lean toward checking at each output as shown in the code
> in bugzilla because it's "cleaner".  I do realize, however, that
> performance is also a consideration here and would like to have your
> input.
> 
> Gary

Reply via email to