[EMAIL PROTECTED] wrote:
> If any of you who regularly use the Xalan tests could 'test' this new stuff
> out, that would be great. In particular, feedback from Tom Amiro and Gary
> Peskin would be great, since I know you two have used this stuff before.
> 8-)
Shane --
Three things so far:
1. This looks great!! It will be nice to get rid of all of the little
files and have everything in Ant. Terrific work.
2. What do you think about replacing the following in build.xml:
<property file="my.test.properties" />
with this:
<property name="propertyFile" value="my.test.properties"/>
<property file="${propertyFile}" />
I like to keep my directories that mirror the repository "clean" so I
don't want to put my "my.test.properties" in there. This change gives
me the option to stick it wherever I want by specifying
"-DpropertyFile=/my-special-place/gary.test.properties"
on the command line.
3. This is very low priority but if I specify in
"gary.test.properties":
conf.logFile=c:/Clean-xalan/results-conf/results.xml
and the results-conf directory is not yet created, I get:
[xalantest] XMLFileLogger.initialize() EXCEPTION:
java.io.FileNotFoundException:
c:/Clean-xalan/results-conf/results.xml
[xalantest] java.io.FileNotFoundException:
c:/Clean-xalan/results-conf/results.xml
[xalantest] at
java.io.FileOutputStream.<init>(FileOutputStream.java:61)
[xalantest] at
java.io.FileOutputStream.<init>(FileOutputStream.java:106)
[xalantest] at java.io.FileWriter.<init>(FileWriter.java:43)
[xalantest] at
org.apache.qetest.XMLFileLogger.initialize(XMLFileLogger.java:337)
[xalantest] at
org.apache.qetest.XMLFileLogger.<init>(XMLFileLogger.java:224)
[xalantest] at
org.apache.qetest.Reporter.addLogger(Reporter.java:468)
[xalantest] at org.apache.qetest.Reporter.initialize(Compiled Code)
[xalantest] at org.apache.qetest.Reporter.<init>(Reporter.java:106)
[xalantest] at
org.apache.qetest.xsl.XSLProcessorTestBase.preTestFileInit(XSLProcessorTestBase.java:337)
[xalantest] at
org.apache.qetest.TestImpl.testFileInit(TestImpl.java:281)
[xalantest] at org.apache.qetest.TestImpl.runTest(TestImpl.java:236)
[xalantest] TestFileInit StylesheetTestletDriver:Test driver for XSLT
stylesheet Testlets
[xalantest] at
org.apache.qetest.xsl.XSLProcessorTestBase.doMain(Compiled Code)
[xalantest] at
org.apache.qetest.xsl.StylesheetTestletDriver.main(StylesheetTestletDriver.java:945)
[xalantest] at
org.apache.qetest.QetestUtils.main(QetestUtils.java:301)
This doesn't happen if results-conf is already created as it is on
subsequent runs. So, you may just want to document that the directory
already has to be there for the conformance testing log file.
Great work!!!
Gary
