DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15042>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15042

"definitley" is definitely spelled wrong.

           Summary: "definitley" is definitely spelled wrong.
           Product: XalanJ2
           Version: 2.4
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: org.apache.xalan.lib.sql
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


This is minor I know... but the attribute "definitley-writeable" as in:

  private static final String S_DEFINITLEYWRITABLE = "definitley-writable";

Is spelled incorrectly. Since this is in output (although just an attribute), 
it should probably be corrected. It would probably be a good idea to also 
correct the similarly mis-spelled variable names, just for correctness. For 
example it looks a bit silly as is in something like:

        addAttributeToNode(
          meta.isDefinitelyWritable(i) ? S_ISTRUE : S_ISFALSE,
          m_ColAttrib_DEFINITLEYWRITEABLE_TypeID, lastColHeaderIdx);

Where the ResultSetMetaData function has it spelled correctly.

P.S. I am not a good speller myself, I just happened to notice this one and for 
some reason it bothered me...

I almost forgot to mention... the problem code is in SQLDocument.java.

Also, if the Xalan community accepts my proposed SQL extension enhancements, I 
would be happy to include this change along with my changes to SQLDocument. Of 
course if the incorrect spelling is grandfathered, that is OK as well.

Art

Reply via email to