[
http://issues.apache.org/jira/browse/XALANJ-2137?page=comments#action_12316492
]
Henry Zongaro commented on XALANJ-2137:
---------------------------------------
Hi, Brian.
I've reviewed your patch of July 13.[1] I'm OK with the approach, but I
noticed a bug in the part of the patch for
org.apache.xalan.xsltc.compiler.Output that is supposed to generate byte code
that specifies the setting of the xalan:use-url-escaping attribute in the
translet. The condition is checking whether _extension_omit_meta_tag is null
instead of checking _extension_use_url_escaping:
+ // Add 'xalan:use-url-escaping' decaration to output - if used
+ if (_extension_omit_meta_tag != null) {
+ field = cpg.addFieldref(TRANSLET_CLASS, "_extUseUrlEsc",
STRING_SIG);
+ il.append(DUP);
+ il.append(new PUSH(cpg, _extension_use_url_escaping));
+ il.append(new PUTFIELD(field));
+ }
Also, a minor comment, earlier in the patch for that same class you have the
following:
+ String extensionPrefix = lookupPrefix("http://xml.apache.org/xalan";);
+ final String uri =
OutputPropertiesFactory.S_BUILTIN_EXTENSIONS_UNIVERSAL;
I believe the value of OutputPropertiesFactory.S_BUILTIN_EXTENSIONS_UNIVERSAL
is "http://xml.apache.org/xalan";, so although its correct as written, it might
be better written as:
+ final String uri =
OutputPropertiesFactory.S_BUILTIN_EXTENSIONS_UNIVERSAL;
+ String extensionPrefix = lookupPrefix(uri);
I would approve the patch if you make at least the first change. The second I
leave to your discretion.
Henry
[1]
http://issues.apache.org/jira/secure/attachment/12311223/July13.2005.patch.for.2137.txt
> XSLTC does not support all extension xsl:output attributes
> ----------------------------------------------------------
>
> Key: XALANJ-2137
> URL: http://issues.apache.org/jira/browse/XALANJ-2137
> Project: XalanJ2
> Type: Bug
> Components: XSLTC
> Reporter: Brian Minchau
> Assignee: Brian Minchau
> Fix For: 2.7.0-future-release
> Attachments: July13.2005.patch.for.2137.txt,
> extension.output.attrs.2137.patch3.txt
>
> XSLTC only handles one xsl:output Xalan extension attribute,
> xalan:indent-amount
> (where the prefix xalan points to URI "http://xml.apache.org/xalan";)
> The full list of extension attributes is:
> xalan:indent-amount
> xalan:content-handler
> xalan:entities
> xalan:omit-meta-tag
> xalan:use-url-escaping
> xalan:line-separator
> These need to be supported in the stylesheet, and via JAXP overrides of what
> is in the stylesheet, e.g.
>
> transformer.setProperty("{http://xml.apache.org/xalan}line-separator","\n";);
> These are all supported by Xalan-J interpretive, but only indent-amount is
> supported by XSLTC, and only in the stylesheet, not through JAXP overrides.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
