[ http://issues.apache.org/jira/browse/XALANJ-2217?page=all ]
Brian Minchau resolved XALANJ-2217:
-----------------------------------
Fix Version: Latest Development Code
Resolution: Fixed
The patch supplied by Dave was reviewed/approved/applied by myself. It was
applied with one exception. The change to ElemNumber was not applied.
I was not convinced that these were the same for a given char, ch:
> String.valueOf(ch)
> (new Character(ch)).toString();
Perhaps they result in the same String, or perhaps in the given context for the
limited range of ch values that would be used they are the same, but I was not
convinced. Also, I checked if this code path was ever taken for the "build
smoketest" or "build alltest.conf" test buckets. The code path was not
exercised, so it also lowered my confidence.
> [PATCH] cleaup some String usage sillyness
> ------------------------------------------
>
> Key: XALANJ-2217
> URL: http://issues.apache.org/jira/browse/XALANJ-2217
> Project: XalanJ2
> Type: Improvement
> Versions: Latest Development Code
> Environment: n/a
> Reporter: Dave Brosius
> Assignee: Brian Minchau
> Priority: Trivial
> Fix For: Latest Development Code
> Attachments: silly_string_stuff.diff
>
> This patch cleans up some String class sillyness like creating an object just
> to convert to string, or calling toString on a String, etc.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
