[ http://issues.apache.org/jira/browse/XALANJ-2061?page=comments#action_12445730 ] Brian Minchau commented on XALANJ-2061: ---------------------------------------
I approve, and have applied the following parts of Dave Brosius patch to the latest development code: ExsltDatetime.java ProcessorExsltFunction.java XSLTAttributeDef.java XSLTAttributeDef.java ElemAttribute.java TransformerIdentityImpl.java TransformerImpl.java ApplyImport.java FunctionAvailable.java MethodGenerator.java FastStringBuffer.java SelfIteratorNoPredicate.java I did not apply the fix to Version.java because this is a generated part. I did not apply the fix to ExtensionHandlerExsltFunction.java because this last store to a variable that is never used is dead code, but then so is a bunch of code leading up to that store. I'd rather just leave it alond for now rather than upset the apple cart. I did not apply the fix to StylesheetHandler.java because it is wrong. The line to be deleted by that part of the patch is not dead code at all. I did not apply the fix to StringValueHandler.java because that dead code actually exposed a bug. It should not be dead code at all. Another issue, XALANJ-2331 now track this. > [Patch] Cleanup some dead code > ------------------------------ > > Key: XALANJ-2061 > URL: http://issues.apache.org/jira/browse/XALANJ-2061 > Project: XalanJ2 > Issue Type: Improvement > Affects Versions: 2.7 > Reporter: Dave Brosius > Assigned To: Brian Minchau > Priority: Trivial > Fix For: Latest Development Code > > Attachments: simple_dls.patch > > > This patch cleans up some unused code -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
