[ http://issues.apache.org/jira/browse/XALANJ-2331?page=comments#action_12447559 ] Brian Minchau commented on XALANJ-2331: ---------------------------------------
triaged November 6, 2006 At the meeting it was decided that this was not a high priority. > StringValueHandler.setEscaping() doesn't return old escaping value > ------------------------------------------------------------------ > > Key: XALANJ-2331 > URL: http://issues.apache.org/jira/browse/XALANJ-2331 > Project: XalanJ2 > Issue Type: Bug > Reporter: Brian Minchau > > Dave Brosius caught some dead code in StringValueHandler.setEscaping() > public boolean setEscaping(boolean bool) { > boolean oldEscaping = m_escaping; > m_escaping = bool; > return bool; > } > Should probably bee > public boolean setEscaping(boolean bool) { > boolean oldEscaping = m_escaping; > m_escaping = bool; > return oldEscaping; > } > Dave's patch in XALANJ-2061 suggests to remove the line boolean oldEscaping = > m_escaping; > since this is dead code. A little investigation of a callers of this method > is that they expect > the previously set value to be returned. So I think we need the fix I suggest. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
