[ 
http://issues.apache.org/jira/browse/XALANJ-2344?page=comments#action_12450976 
] 
            
Brian Minchau commented on XALANJ-2344:
---------------------------------------

I must reject ElemUse.patch.txt.  

My initial review of the patch is that it looks fine. However it fails the most 
basic smoketest.  The traceback shows a failure (or rather lots of them) on 
line 1620 of  XSLTAttributeDef.java, which is this:
   meth = elem.getClass().getMethod(setterString, argTypes);

Java reflection is being done, and the change in signature of 
ElemUse.setUseAttributeSets() from taking a Vector to a List is messing up the 
reflection code which fails to find the method. This "soft" reference to the 
function cannot be found at compile time, only at runtime (hey... why else 
would you want to user Java reflection, but to determine things at runtime).

> Xalan-J should stop using java.util.Vector in some cases (NOT a clone of 2336)
> ------------------------------------------------------------------------------
>
>                 Key: XALANJ-2344
>                 URL: http://issues.apache.org/jira/browse/XALANJ-2344
>             Project: XalanJ2
>          Issue Type: Improvement
>          Components: Xalan
>    Affects Versions: Latest Development Code
>            Reporter: Toadie D
>         Attachments: ElemLiteralResult.patch.txt, ElemTextLiteral.patch.txt, 
> ElemUse.patch.txt, StylesheetRoot+XSLTSchema.patch.txt, 
> StylesheetRoot.patch.txt
>
>
> ref:  https://issues.apache.org/jira/browse/XALANJ-2336
> This bug is related to 2336 but is NOT a clone.  The patches provided here 
> are in addition to the ones in 2336.  Furthermore, these patches are created 
> AFTER the patch in 2336 are applied.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to