[ 
https://issues.apache.org/jira/browse/XALANC-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513584
 ] 

Dmitry Hayes commented on XALANC-648:
-------------------------------------

I have two comments : first , I tried to rebuild XalanC first time for pretty 
long time and it seems that we have some build errors :
d:\LatestXalanC\src\xalanc\PlatformSupport\XalanLocator.hpp(94): error C2555: 
'xalanc_1_10::XalanLocator::getColumnNumber': overriding virtual function 
return type differs and is not covariant from 
'xercesc_2_7::Locator::getColumnNumber'

Xercec Locator::getColumnNumber() const ; returns XMLSSize_t , but 
XalanLocator::getColumnNumber() const return "unsigned long", and the compiler 
doesn't like it. Is it something new , I probably missed some latest additions. 

2. Looking into the attached patch , I see some if(..) ... else's rearanged , 
but I can't find a scenario exposing the potential defect . Can you provide one 
? 

Thanks!


> XalanUTF8Writer::write(const XalanDOMChar*, XalanDOMString::size_type) does 
> not handle surrogates properly
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: XALANC-648
>                 URL: https://issues.apache.org/jira/browse/XALANC-648
>             Project: XalanC
>          Issue Type: Bug
>    Affects Versions: CurrentCVS
>            Reporter: David Bertoni
>            Assignee: David Bertoni
>         Attachments: patch.diff
>
>
> This function needs to decode surrogate pairs into the corresponding Unicode 
> code point, just like the other write() overloads.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to