[
https://issues.apache.org/jira/browse/XALANC-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513588
]
Dmitry Hayes commented on XALANC-647:
-------------------------------------
I agree that every numeric character reference should be representable , but
wouldn't be direct approach to the buffer little bit risky ? I thought that we
had something like "writeSafe" functions for writing "always presentable" code
points . And there is a risk of "famous" buffer overrun problem : if the
buffer happens to be defined small , even after the flush it may happen not to
have enouph room to keep the "number". Thanks!
> XalanOtherEncodingWriter::writeNumericCharacterReference() is inefficient
> -------------------------------------------------------------------------
>
> Key: XALANC-647
> URL: https://issues.apache.org/jira/browse/XALANC-647
> Project: XalanC
> Issue Type: Bug
> Affects Versions: CurrentCVS
> Reporter: David Bertoni
> Assignee: David Bertoni
> Attachments: patch.diff
>
>
> This function formats a numeric character reference for any character that is
> not representable in the code page. However, it uses the write() function to
> write the numeric character reference, which will then check each character
> to see if it can be represented in the local code page. This is unnecessary,
> since the characters in a numeric character reference must be representable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
