[
https://issues.apache.org/jira/browse/XALANC-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721508#action_12721508
]
David Bertoni commented on XALANC-692:
--------------------------------------
This patch will not work with all of our support platforms either, particularly
Windows.
The best fix is to stop accepting case-insensitive command line arguments.
Since this test is no longer used, that's the easiest thing to do.
> stricmp is missing in some operating systems
> ---------------------------------------------
>
> Key: XALANC-692
> URL: https://issues.apache.org/jira/browse/XALANC-692
> Project: XalanC
> Issue Type: Bug
> Components: XalanC
> Affects Versions: 1.10
> Environment: OpenSolaris x86
> Reporter: Meena
> Assignee: David Bertoni
>
> This patch works :
> $cat dom2dom.cpp.patch perf.cpp.patch
> --- ./xml-xalan/c/Tests/Dom2Dom/dom2dom.cpp 2008-08-21 09:30:15.549225851
> +0530
> +++ ./xml-xalan/c/Tests/Dom2Dom/dom2dom.cpp.new 2008-08-21 09:30:15.581378120
> +0530
> @@ -142,7 +142,7 @@
> // Get the rest of the arguments in any order.
> for (int i = 2; i < argc && fSuccess == true; ++i)
> {
> - if(!stricmp("-out", argv[i]))
> + if(!strcasecmp("-out", argv[i]))
> {
> ++i;
> if(i < argc && argv[i][0] != '-')
> --- ./xml-xalan/c/Tests/Performance/perf.cpp 2008-08-21 09:30:15.573607941
> +0530
> +++ ./xml-xalan/c/Tests/Performance/perf.cpp.new 2008-08-21
> 09:30:15.590926855 +0530
> @@ -198,7 +198,7 @@
> int i = 1;
> while (i < argc)
> {
> - if (stricmp(argv[i],"-test") == 0)
> + if (strcasecmp(argv[i],"-test") == 0)
> {
> ++i;
> if (i >= argc)
> @@ -209,7 +209,7 @@
> }
> testDirectory.assign(argv[i]);
> }
> - else if (stricmp(argv[i],"-result") == 0)
> + else if (strcasecmp(argv[i],"-result") == 0)
> {
> ++i;
> if (i >= argc)
> @@ -220,7 +220,7 @@
> }
> resultDirectory.assign(argv[i]);
> }
> - else if (stricmp(argv[i],"-baseline") == 0)
> + else if (strcasecmp(argv[i],"-baseline") == 0)
> {
> ++i;
> if (i >= argc)
> @@ -231,7 +231,7 @@
> }
> baselineDirectory.assign(argv[i]);
> }
> - else if (stricmp(argv[i],"-report") == 0)
> + else if (strcasecmp(argv[i],"-report") == 0)
> {
> ++i;
> if (i >= argc)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
