Whoops sorry forgot to add the license file, it's on git now. I went with
the MIT license since it's super open and short. Yeah go ahead and pull it
now it will be a while till I get the queuing working. I'll put in a new
pull request when I make the upgrades or get it working for Eden.
Jesse
On Sat, Nov 19, 2011 at 6:14 AM, Sascha Montellese <
sascha.montell...@gmail.com> wrote:
> You are still missing a license file. As XBMC is open source we have to be
> very strict about this when it comes to the official addon repository.****
>
> ** **
>
> Let me know whether I should add your addon to the repo (once you’ve added
> a license) or if you want to take a stab at queuing a whole album first.
> That feature is not a must it’s just something I noticed ;-)****
>
> ** **
>
> And once you got an Eden-pre compatible version available just send
> another pull request for it. If you need help with some of the JSON-RPC
> changes feel free to ask in http://forum.xbmc.org/showthread.php?t=68263**
> **
>
> ** **
>
> Best regards****
>
> ** **
>
> ** **
>
> *Von:* sol...@gmail.com [mailto:sol...@gmail.com] *Im Auftrag von *Jesse
> Foltz
> *Gesendet:* Samstag, 19. November 2011 11:59
> *An:* Sascha Montellese
> *Betreff:* Re: [Xbmc-addons] [Git Pull] Home Row - XBMC Web Interface****
>
> ** **
>
> I've fixed the logo and removed the read me. Yeah I hadn't tested it in
> Eden yet I knew there were a bunch of changes to the JSON RPC. I'll have to
> make a branch for it.****
>
> ** **
>
> As for the queuing of other songs in a folder I haven't gotten that
> working yet. I think it will be easier to implement for Eden. But I'll give
> it a shot for music files in Dharma.****
>
> ** **
>
> Jesse****
>
> On Sat, Nov 19, 2011 at 4:25 AM, Sascha Montellese <
> sascha.montell...@gmail.com> wrote:****
>
> Hey Jesse****
>
> ****
>
> Thanks for submitting the pull request for your webinterface.****
>
> Here are a few general things that you need to change (see also
> http://wiki.xbmc.org/index.php?title=Official_Add-on_Repository_Guidelines
> ):****
>
> · You need to add a license file to your webinterface containing
> the license you chose****
>
> · The addon logo must not contain any transparency (see also
> http://wiki.xbmc.org/index.php?title=Add-ons_for_XBMC_(Developement)#Guidlines_for_images)
> ****
>
> · You have an empty README file in your repository. Either remove
> it or add some useful content****
>
> ****
>
> Now concerning the webinterface itself:****
>
> · When using it with Eden-pre I don’t see anything apart from
> placeholders. No matter what I do (type something in the search field or
> click one of the placeholders) I can’t get any real information.
> Furthermore I get the following javascript error in firebug everytime I
> click something: “selectedSubNode is undefined” in type-xbmc.js line 495**
> **
>
> · When using it with Dharma I can browse movies, tv shows and
> albums without any problem and start playback of items. The only unexpected
> behaviour I found was that starting a song does only queue that single song
> and not the whole album so Skip Next doesn’t work because there is only one
> song in the playlist.****
>
> · I took a glance at your code and there are a few things that
> won’t work for Eden-pre. JSON-RPC has changed a lot since Dharma and you
> won’t be able to use the same methods to get your webinterface working in
> Dharma and in Eden. One example is XBMC.Play which appears throughout your
> code but doesn’t exists anymore in Eden-pre (it was replaced by Player.Open)
> ****
>
> ****
>
> So if you can fix up the general things I mentioned first your
> webinterface could be added to the official dharma repo but if you want it
> to get added for Eden (which would be very welcome) you will have to create
> a separate branch for that work and fix the JSON-RPC calls. An API overview
> for Eden-pre can be found at
> http://wiki.xbmc.org/index.php?title=JSON-RPC_API/v3 and at
> http://wiki.xbmc.org/index.php?title=Eden_API_Changes#JSON-RPC you can
> find an (incomplete) list of changes to JSON-RPC since Dharma.****
>
> ****
>
> ****
>
> *Von:* Jesse Foltz [mailto:jesse.fo...@gmail.com]
> *Gesendet:* Samstag, 19. November 2011 00:27
> *An:* xbmc-addons@lists.sourceforge.net
> *Betreff:* [Xbmc-addons] [Git Pull] Home Row - XBMC Web Interface****
>
> ****
>
> *addon - webinterface.home-row
> *version - 0.1.0
> *url - git://github.com/soljin/Home-Row-XBMC.git
> *revision - 73c77244ec
> *branch - master
> *xbmc version - dharma, eden-pre ****
>
> ** **
>
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
