On 17/12/12 13:07, Bruce Pauw wrote: > > *addon - skin.hybrid > *version - 1.0.1 > *url - https://github.com/Mudislander/skin.hybrid.git > *revision - cc7646e60c1b7cb878801fbd461c699649ee3af0 > *branch - master > *xbmc version - frodo > > Please consider skin.hybrid for XBMC "Frodo" Repo > > Current forum thread http://forum.xbmc.org/showthread.php?tid=143788 > > Cheers > > Mudislander
hi Mudislander, great to see we have a new skin on the block :-) as with every first pull, it's gonna take a bit of effort to get things in the right shape, but once that is completed, future pull request will go much smoother. and should it be a comfort to you, we all had to wrestle ourselves through the first round. so fasten your seatbelts, here's the list of things i've found: skin.hybrid/_screenshots all images need to be 1280x720 skin.hybrid/README.md remove this file skin.hybrid/media/UsrStatus remove this folder + contents skin.hybrid/media/MediaFlags/studios remove images with corrupted filenames, there are many of them, like: - Pathe¬n Fre¬ªres.png - Pathe+n Fre+¼res.png skin.hybrid/language/English/strings.xml you have a .po file, so remove the .xml one skin.hybrid/720p/DialogMediaFilter.xml this file is missing. without it, the filter function on the side menu in the library is broken. http://forum.xbmc.org/showthread.php?tid=126502&pid=1220234#pid1220234 skin.hybrid/backgrounds/weather/weather.txt: Windows (CRLF) change to unix EOL skin.hybrid/720p/MusicVisualisation.xml remove the BOM character at the start of the file skin.hybrid/720p/ViewsLogoHorizontal.xml some hardcoded strings, please localize them: Episodes, Plot, Tv show information skin.hybrid/720p/includes.xml Error loading includes.xml file (/home/ronie/.xbmc/addons/skin.hybrid/720p/IncludesHomeNowPlaying.xml): Failed to open file (row=0, col=0) skin.hybrid/720p/DialogVideoInfo.xml ERROR: unmatched parentheses in system.hasaddon(script.artwork.downloader skin.hybrid/720p/ViewsEpisodes.xml WARNING: Skin has invalid include: VideoMPAAFlaggingConditions one thing that worries me is all the skin xml changed you've pushed right before sending this pull-request. have all those changes been tested for a while by our users and verified not to introduce some bugs? if you have any questions or need help with any of the above, just ask! cheers, ronie ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
