Hey Jesse
Thanks for submitting your webinterface to the Frodo repository.
There are a few things that I noticed that need to be adjusted:
· In your pull request you state version “1.5.9” but in your addon.xml
the version is “1.5.6”. Furthermore that’s the same version as is already
present in the Eden repository which is not allowed. You need to make a major
version bump so that it is still possible to update the addon in the Eden
repository without any conflicting version numbers. I propose to either go to
1.6.0 or 1.6.6 or 2.0.0 or something like that for the version in the Frodo
repository.
· You need to update the versions of the imports of xbmc.gui to “4.0.0”
and of xbmc.json to “6.0.0”
· This is not mandatory but having a changelog.txt file (see
http://wiki.xbmc.org/index.php?title=Add-on_development#changelog.txt ) makes
it easier for users (and us) to follow what has changed between versions.
Please send an updated pull request once the first two issues have been
addressed.
Thanks
Montellese
Von: Jesse Foltz [mailto:jessefo...@jessefoltz.com]
Gesendet: Sonntag, 3. Februar 2013 07:46
An: xbmc-addons@lists.sourceforge.net
Betreff: [Xbmc-addons] Home Row - XBMC Web Interface
addon - webinterface.home-row
version - 1.5.9
url - git://github.com/soljin/Home-Row-XBMC.git
revision - e9ffd9235f
branch - frodo
xbmc version - frodo
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_jan
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
