It's all good for the line endings, but unfortunately your icon.png and error.png got corrupted in the process (I guess). You should add the following to your .gitattributes: """ # Make sure those files will not be modified *.png binary *.jpg binary """
and recommit those files. You should always send your pull request to the mailing list. It was in copy here, so that was fine. If you send it only to me, it won't get catch by my filter and I might miss it. For your information, here is the script I use to process pull requests: https://github.com/beenje/addon-pr Not sure it works on windows. Cheers /beenje On Fri, Mar 22, 2013 at 9:52 AM, Aybars Badur <ayb...@pilli.com> wrote: > *addon - plugin.video.putiov2 > *version - 0.0.3 > *url - g...@github.com:ybrs/putio-xbmc-v2.git > *revision - 76831fb943b33b151f28cbdffa8c40b8213594bf > *branch - frodo > *xbmc version - frodo > > My apologies, I made a typo in .gitattributes file, now it should be fine, > > If its still not, can you please let me know how you are checking the line > endings, so I can double check and make sure before I submit again. > > And also do I need to send a pull request to mail list again ? > > Thank you and again sorry for taking your time too much. > > On Thu, Mar 21, 2013 at 11:55 PM, Benjamin Bertrand > <bee...@xboxmediacenter.com> wrote: >> >> You are still using CRLF line endings. >> Check this page: >> >> https://help.github.com/articles/dealing-with-line-endings#platform-windows >> >> If you still need help after, you can come back to me. >> >> Cheers >> >> On Thu, Mar 21, 2013 at 9:32 PM, Aybars Badur <ayb...@pilli.com> wrote: >> > *addon - plugin.video.putiov2 >> > *version - 0.0.3 >> > *url - g...@github.com:ybrs/putio-xbmc-v2.git >> > *revision - 43e132dc511c57bdf67b0be6d26aaa65ad11dd12 >> > *branch - frodo >> > *xbmc version - frodo >> > >> > Hi, >> > >> > I made the changes Benjamin Bertrand requested - sorry for taking your >> > time >> > -, please feel free to comment if there is still anything wrong. >> > >> > Thank you, >> > -- >> > >> > Aybars Badur >> > >> > Lead Developer, Put.io >> > >> > DON'T PANIC >> > >> > >> > ------------------------------------------------------------------------- >> > >> > LinkedIn: http://www.linkedin.com/in/aybarsb >> > >> > Twitter: http://twitter.com/aybarsbadur >> > >> > >> > >> > >> > >> > ------------------------------------------------------------------------------ >> > Everyone hates slow websites. So do we. >> > Make your web apps faster with AppDynamics >> > Download AppDynamics Lite for free today: >> > http://p.sf.net/sfu/appdyn_d2d_mar >> > _______________________________________________ >> > Xbmc-addons mailing list >> > Xbmc-addons@lists.sourceforge.net >> > https://lists.sourceforge.net/lists/listinfo/xbmc-addons >> > > > > > > -- > > Aybars Badur > > Lead Developer, Put.io > > DON'T PANIC > > ------------------------------------------------------------------------- > > LinkedIn: http://www.linkedin.com/in/aybarsb > > Twitter: http://twitter.com/aybarsbadur > > > ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar _______________________________________________ Xbmc-addons mailing list Xbmc-addons@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xbmc-addons
