updated
thx
regards,
Martijn Kaijser
Team XBMC
On Tue, Nov 19, 2013 at 8:54 PM, bierdopje subtitles <
bierdopje.subtit...@gmail.com> wrote:
> I changed the icon and added a logo.png:
>
> addon - service.subtitles.bierdopje
> version - 5.0.1
> url - git://github.com/mr-blobby/service.subtitles.bierdopje.git
> revision - a66b2b7286d2d14a1b0504e5556d82085fbe8085
> branch - master
> xbmc version - gotham
>
>
> On Mon, Nov 18, 2013 at 10:59 PM, Martijn Kaijser <mart...@xbmc.org>wrote:
>
>> fyi see for adding logo.png
>>
>> https://github.com/amet/OpenSubtitles-service/commit/632904859a346fddafb0d8a8157337ae03d6351f
>>
>> regards,
>> Martijn Kaijser
>> Team XBMC
>>
>>
>> On Mon, Nov 18, 2013 at 10:06 PM, Martijn Kaijser <mart...@xbmc.org>wrote:
>>
>>> See my comments here.
>>> https://github.com/xbmc/xbmc/pull/3552#issuecomment-28720586
>>> this needs some changes in XBMC code as we do not allow non square
>>> icon.png and this was simply missed when doing the change.
>>>
>>> Will pull this in for now until it's resolved in XBMC code and the addon
>>> can be updated to have square icon.png and a proper skin logo
>>>
>>> regards,
>>> Martijn Kaijser
>>> Team XBMC
>>>
>>>
>>> On Mon, Nov 18, 2013 at 9:57 PM, bierdopje subtitles <
>>> bierdopje.subtit...@gmail.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> I've changed everything that was asked, except for the icon.
>>>> When I change the icon to a 256x256 square, it shows up very, very tiny
>>>> on the new subtitles window that is now part of the core of XBMC.
>>>> Also, I've used the Opensubtitles service from Amet (
>>>> https://github.com/amet/OpenSubtitles-service) as a reference, and he
>>>> doesn't have a square icon.
>>>> Please let me know if there is a way I can control which icon should be
>>>> used in the subtitles window.
>>>> Then I would be more then happy to provide a separate square "default"
>>>> icon and another icon that is used in the subtitles window.
>>>>
>>>> Anyway, the updated info:
>>>>
>>>> addon - service.subtitles.bierdopje
>>>> version - 5.0.0
>>>> url - git://github.com/mr-blobby/service.subtitles.bierdopje.git
>>>> revision - 75e044695c5d94dfdb40e1f6c192473c9c41ad0d
>>>> branch - master
>>>> xbmc version - gotham
>>>>
>>>> Regards,
>>>>
>>>> Edwin
>>>>
>>>>
>>>> On Mon, Nov 18, 2013 at 6:27 PM, Martijn Kaijser <mart...@xbmc.org>wrote:
>>>>
>>>>> Several things.
>>>>> - please make sure all GUI visible strings are translatable
>>>>> http://wiki.xbmc.org/index.php?title=Add-on_development#.2Fresources.2Flanguage.2F
>>>>> - please also fill in extended addon.xml information
>>>>> http://wiki.xbmc.org/index.php?title=addon.xml#The_xbmc.addon.metadata_extension
>>>>> - move the files to the root of github for easier repo processing.
>>>>> - icon needs to be square, non transparent 256x256
>>>>>
>>>>> Martijn
>>>>>
>>>>>
>>>>> regards,
>>>>> Martijn Kaijser
>>>>> Team XBMC
>>>>>
>>>>>
>>>>> 2013/11/18 bierdopje subtitles <bierdopje.subtit...@gmail.com>
>>>>>
>>>>>> addon - service.subtitles.bierdopje
>>>>>> version - 5.0.0
>>>>>> url - git://github.com/mr-blobby/service.subtitles.bierdopje.git
>>>>>> revision - 2f2834e
>>>>>> branch - master
>>>>>> xbmc version - gotham
>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------------------------
>>>>>> DreamFactory - Open Source REST & JSON Services for HTML5 & Native
>>>>>> Apps
>>>>>> OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
>>>>>> Free app hosting. Or install the open source package on any LAMP
>>>>>> server.
>>>>>> Sign up and see examples for AngularJS, jQuery, Sencha Touch and
>>>>>> Native!
>>>>>>
>>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
>>>>>> _______________________________________________
>>>>>> Xbmc-addons mailing list
>>>>>> Xbmc-addons@lists.sourceforge.net
>>>>>> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing
conversations that shape the rapidly evolving mobile landscape. Sign up now.
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
