1. This is a script, not a plugin. Would it be ok to rename it
"script.audio.pandora" or "script.pandora" for consistency?

2. Remove the Thumbs.db files:
addonpr.addonparser - ERROR   -
plugin.audio.pandora/resources/skins/Alaska/media/Thumbs.db is not
allowed
addonpr.addonparser - ERROR   -
plugin.audio.pandora/resources/skins/Smoke/media/Thumbs.db is not
allowed

3. Please add the language tag. See
http://wiki.xbmc.org/index.php?title=Addon.xml#.3Clanguage.3E

4. I saw you know setting PLAYER_CORE_* is deprecated, but it seems
you need it, so it's ok for now.

5. Please add xml header with proper encoding to all your xml files:
addonpr.addonparser - ERROR   - No xml encoding specified in
plugin.audio.pandora/resources/settings.xml
addonpr.addonparser - ERROR   - No xml encoding specified in
plugin.audio.pandora/resources/skins/Alaska/skin.xml
addonpr.addonparser - ERROR   - No xml encoding specified in
plugin.audio.pandora/resources/skins/Alaska/720p/script-pandora.xml
addonpr.addonparser - ERROR   - No xml encoding specified in
plugin.audio.pandora/resources/skins/Alaska/NTSC/script-pandora.xml
addonpr.addonparser - ERROR   - No xml encoding specified in
plugin.audio.pandora/resources/skins/Default/skin.xml
addonpr.addonparser - ERROR   - No xml encoding specified in
plugin.audio.pandora/resources/skins/Default/720p/script-pandora.xml
addonpr.addonparser - ERROR   - No xml encoding specified in
plugin.audio.pandora/resources/skins/Default/NTSC/script-pandora.xml
addonpr.addonparser - ERROR   - No xml encoding specified in
plugin.audio.pandora/resources/skins/Smoke/skin.xml
addonpr.addonparser - ERROR   - No xml encoding specified in
plugin.audio.pandora/resources/skins/Smoke/720p/script-pandora.xml
addonpr.addonparser - ERROR   - No xml encoding specified in
plugin.audio.pandora/resources/skins/Smoke/NTSC/script-pandora.xml

6. If possible, try to replace print statements with xbmc.log()



On Wed, Jan 22, 2014 at 1:21 AM, Roy Ivy III <rivy....@gmail.com> wrote:
> * addon -   plugin.audio.pandora
> * version - 2.3.1
> * url - git://github.com/rivy/xbmc-plugin.audio.pandora.git
> * revision - 011e214
> * branch - master
> * tag - R-v2.3.1
> * xbmc version - frodo + gotham
>
> Pandora Radio for XBMC
> + adds the ability to listen to Pandora audio streams
> + mature, in-use / development for almost 4 years
>
> Thanks for the consideration.
> --
> Roy
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> Xbmc-addons mailing list
> Xbmc-addons@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/xbmc-addons
>

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to