Hi there. I'd like to have this skin reconsidered for the official Gotham
repo please.

*addon - skin.maximinimalism
*version - 1.0.0
*url - https://github.com/chrisbevan/skin.maximinimalism
*revision - 64b00f4775a98a4537bf16cc073e5834daab6a78
*branch - master
*xbmc version - gotham

Cheers,
Chris.

---- CHANGELOG SINCE LAST SUBMISSION ----

[FIXED] screenshots in the _screenshots folder need to be 1280x720px
[FIXED] language strings should be in the 31xxx range
[FIXED] rename these files:
  ./colors/Defaults.xml  -> ./colors/defaults.xml
./1080i/DialogSeekbar.xml -> ./1080i/DialogSeekBar.xml
./1080i/viewsPictures.xml -> ./1080i/ViewsPictures.xml
./1080i/includes_animations.xml -> ./1080i/Includes_animations.xml
[FIXED] disable debuginfo by default

[FIXED - I THINK...] these file have a BOM character at the start of the
file, please remove the BOM:
./1080i/MusicOSD.xml
./1080i/DialogContextMenu.xml
./1080i/DialogSeekbar.xml
./1080i/DialogProgress.xml
./1080i/DialogYesNo.xml
./1080i/Startup.xml
./1080i/DialogOk.xml
./1080i/DialogNetworkSetup.xml

[FIXED] xml validation fails for these files:use & instead of &:
./1080i/MyVideoNav.xml:793.65: EntityRef: expecting ';'
<onclick>RunScript(script.globalsearch,movies=true&tvshows=true&episodes=t

./1080i/MyMusicPlaylist.xml:489.65: EntityRef: expecting ';'
<onclick>RunScript(script.globalsearch,artists=true&albums=true)</onclick>

./1080i/MyMusicNav.xml:752.65: EntityRef: expecting ';'
<onclick>RunScript(script.globalsearch,artists=true&albums=true)</onclick>

./1080i/MyMusicSongs.xml:514.65: EntityRef: expecting ';'
<onclick>RunScript(script.globalsearch,artists=true&albums=true)</onclick>

[FIXED] ./1080i/DialogNumeric.xml:129.5: StartTag: invalid element name
<--row 2-->
./1080i/script-globalsearch-main.xml:602.7: StartTag: invalid element name
<--found episodes-->

[FIXED] these files need to be converted to unix style EOL's:
1080i/DialogKaraokeSongSelector.xml: Windows (CRLF)
1080i/DialogKaraokeSongSelectorLarge.xml: Windows (CRLF)
1080i/DialogTextViewer.xml: Windows (CRLF)
1080i/MusicKaraokeLyrics.xml: Windows (CRLF)
1080i/SlideShow.xml: Windows (CRLF)
1080i/SmartPlaylistEditor.xml: Windows (CRLF)
1080i/SmartPlaylistRule.xml: Windows (CRLF)
fonts/sourceSansPro/license.txt: Windows (CRLF)
LICENSE.txt: Windows (CRLF)

[FIXED] the use of '-' in onclick is not valid, please use
<onclick>noop</onclick> in the following files:
1080i/MyWeather.xml
1080i/MyPVR.xml
1080i/SettingsSystemInfo.xml
- the same applies to <onleft>, used in this file:
1080i/MyMusicPlaylistEditor.xml

[FIXED] these files are marked as executable, please remove the executable
bit:
./fonts/sourceSansPro/license.txt
./fonts/symbol.ttf

[FIXED] undefined Vars: itemdetail, ViewsVideos.xml (2x)

[FIXED] unmatched parenthesis in Includes_variables.xml:

- mandatory xml files missing (they're empty):
[FIXED] DialogSongInfo.xml [FIXED]
[FIXED] DialogFileStacking.xml [FIXED]
[FIXED] MyVideoPlaylist.xml [FIXED]
[FIXED] VisualisationPresetList.xml [FIXED]
[FIXED] MusicOSD.xml [functionality replicated in custom dialog]

[FIXED] missing player controls
both VideoOSD.xml as well as MusicOSD.xml need a set of
stop/play/pause/next/etc.. buttons

[FIXED] livetv - could be me, but i can't find the radio channels list?

[FIXED] remove this file: MyVideo.xml (it's not used anymore in frodo)

[FIXED] remove the <defaultcontrol> definition in DialogKaiToast.xml

[FIXED] one error i found in the log while running the skin:
00:17:59 T:140441358894976   ERROR: Keymapping error: no such action
'container.setviewmode()' defined
00:17:59 T:140441358894976   DEBUG: ExecuteXBMCAction : Tried
translating, but failed to understand
Container.SetViewMode($VAR[videoViewType])

//TO NEGOTIATE

script-globalsearch-contextmenu.xml (either remove this one, or include
a functional one)
[I disable this as identical functionality is provided by the item info
screen]

- skins should not interfere with music or video playback,
video playback stops when exiting fullscreen
music playback stops when entering pictures
[I've revised to allow music playback in the pictures section. I'd like to
prevent active video streams behind the menus however]
------------------------------------------------------------------------------
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to