On 14-12-14 13:59, Piers Hausjell wrote:
>  *addon -   skin.Xperience1080
>  *version - 3.4.0
>  *url - https://github.com/vonH/Xperience1080.git
>  *revision - 00000000 (not sure what this part means)
>  *branch - master
>  *kodi version - helix
>

hi Piers,

thanx for submitting Xperience1080 to the addon repo!

the pull request is just fine, so no worries about that :-)
Martijn already explained the revision bit to you.


i gave Xperience1080 a spin and came across some issues that would 
require your attention:

addon.xml
- addon id should be in lower-case (skin.xperience1080)
- provider-name should be in this format: "Piers|xhaggi|Black"
- the file starts with a 'BOM character', please remove it


please rename these files:
colors/Defaults.xml -> colors/defaults.xml  (case sensitive issue)
script-XBMC_Lyrics-main.xml ->  script-cu-lrclyrics-main.xml
(see: http://forum.kodi.tv/showthread.php?tid=194515&pid=1773071#pid1773071)


please delete this file:
MyPVR.xml (file is not needed anymore in Helix)


could you change this to a Kodi logo?
media/settings/xbmc-logo.png
(artwork available here: http://kodi.wiki/view/Official:Media_center_logos)


DialogPVRRecordingInfo.xml - Undefined Include: 
<include>PVRGuideInfo</include>


DialogPictureInfo.xml
the dialog doesn't show the exif values. probably a label alignment issue.



if you have any question or need help with those, please don't hesitate 
to ask :-)


cheers,
ronie

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Xbmc-addons mailing list
Xbmc-addons@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xbmc-addons

Reply via email to