On 25-02-15 03:24, Cooper Beilby wrote:
> Hi, think I'm ready for repo inclusion now. Eagerly awaiting the
> massive list of things I need to fix ;) :P
>
> * addon - skin.arctic.zephyr
> * version - 1.0.0
> * url - https://github.com/jurialmunkey/skin.arctic.zephyr
> * revision - 5e3b51c52ac05e12116cfccbabf62c3cbecf5821
> * branch - master
> * kodi version - Helix
>
> thx,
> Cooper.
>
hey Cooper,
thanx for submitting your new skin to the addon repo!
since you've asked for it, i prepared an extra long list, just for you ;-p
addon.xml - case issue:
defaultthemename="textures.xbt" -> Textures.xbt
rename this files:
LICENSE -> LICENSE.txt
these files fail xml validation:
./1080i/Includes_Home.xml
<focusedlayout width="178" height="257"condition="!subst
(missing space between height and condition)
./1080i/DialogPeripheralManager.xml
<control type="label id="1">
(missing quotation mark after label)
./1080i/DialogPeripheralManager.xml
<label>$INFO[ListItem.Label]</label
(missing bracket after /label)
./1080i/DialogPeripheralSettings.xml
<control type="label id="1">
(missing quotation mark after label)
./1080i/DialogSelect.xml:1.6: XML declaration allowed only at the start
of the document
<?xml version="1.0" encoding="UTF-8"?>
(remove the spaces before the xml declaration)
remove the BOM character at the start of these files:
./1080i/MusicOSD.xml
./1080i/DialogContextMenu.xml
./1080i/DialogSeekBar.xml
./1080i/Custom_Debug_Overlay.xml
./1080i/DialogOK.xml
./1080i/DialogProgress.xml
./1080i/DialogYesNo.xml
./1080i/Startup.xml
./1080i/DialogNetworkSetup.xml
please change these files to use unix styl EOL's:
1080i/DialogKaraokeSongSelector.xml: Mixed, predominantly Windows (CRLF)
1080i/DialogKaraokeSongSelectorLarge.xml: Mixed, predominantly Windows
(CRLF)
1080i/DialogMediaFilter.xml: Mixed, predominantly Unix (LF)
1080i/DialogPeripheralManager.xml: Mixed, predominantly Windows (CRLF)
1080i/DialogPeripheralSettings.xml: Mixed, predominantly Windows (CRLF)
1080i/DialogTextViewer.xml: Mixed, predominantly Windows (CRLF)
1080i/MusicKaraokeLyrics.xml: Mixed, predominantly Windows (CRLF)
1080i/SlideShow.xml: Mixed, predominantly Unix (LF)
1080i/SmartPlaylistEditor.xml: Mixed, predominantly Windows (CRLF)
1080i/SmartPlaylistRule.xml: Mixed, predominantly Windows (CRLF)
1080i/VideoOSDSettings.xml: Mixed, predominantly Unix (LF)
Undefined includes:
MyWeather.xml: GoBackToHome
VideoOSD.xml: VideoOSDFullscreen (2x)
DialogButtonMenu.xml: SettingsLabel
Unmatched parenthesis:
DialogPVRGuideOSD.xml: IsEmpty(Player.Art(thumb)
Undefined IDs:
Includes_Furniture.xml: 3203
Includes_Furniture.xml: 3204 (2x)
DialogKaiToast:
ERROR: Control 402 in window 10107 has been asked to focus, but it can't
(remove the defaultcontrol definition)
feel free to ask for help in case anything is not clear to you.
cheers,
ronie
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Xbmc-addons mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/xbmc-addons
