Below is a diff to the codebase that will make the changes

$ git diff
diff --git a/trunk/conserver/debian/patches/initscript.patch
b/trunk/conserver/debian/patches/initscript.patch
index db9323a..6a44809 100644
--- a/trunk/conserver/debian/patches/initscript.patch
+++ b/trunk/conserver/debian/patches/initscript.patch
@@ -62,7 +62,7 @@ diff -urN
conserver-8.1.16/contrib/redhat-rpm/conserver.init conserver-8.1.16-di

  # make sure conserver is installed and executable
  [ -x /usr/sbin/conserver  ] || exit 1
-@@ -24,23 +62,44 @@
+@@ -24,23 +62,45 @@
  case "$1" in
    start)
      echo -n "Starting conserver: "
@@ -82,7 +82,7 @@ diff -urN
conserver-8.1.16/contrib/redhat-rpm/conserver.init conserver-8.1.16-di
 +    if [ "$?" != "0" ]; then
 +        echo -n "conserver not running, not stopping "
 +        $PASSED
-+        exit 1
++        exit 0
 +    fi
      echo -n "Shutting down conserver: "
      killproc conserver
@@ -98,6 +98,7 @@ diff -urN
conserver-8.1.16/contrib/redhat-rpm/conserver.init conserver-8.1.16-di
    status)
 -    status conserver
 +    $STATUS conserver
++    return $?
      ;;
    restart)
 -    echo -n "Restarting conserver: "
diff --git a/trunk/conserver/initscript.patch
b/trunk/conserver/initscript.patch
index db9323a..6a44809 100644
--- a/trunk/conserver/initscript.patch
+++ b/trunk/conserver/initscript.patch
@@ -62,7 +62,7 @@ diff -urN
conserver-8.1.16/contrib/redhat-rpm/conserver.init conserver-8.1.16-di

  # make sure conserver is installed and executable
  [ -x /usr/sbin/conserver  ] || exit 1
-@@ -24,23 +62,44 @@
+@@ -24,23 +62,45 @@
  case "$1" in
    start)
      echo -n "Starting conserver: "
@@ -82,7 +82,7 @@ diff -urN
conserver-8.1.16/contrib/redhat-rpm/conserver.init conserver-8.1.16-di
 +    if [ "$?" != "0" ]; then
 +        echo -n "conserver not running, not stopping "
 +        $PASSED
-+        exit 1
++        exit 0
 +    fi
      echo -n "Shutting down conserver: "
      killproc conserver
@@ -98,6 +98,7 @@ diff -urN
conserver-8.1.16/contrib/redhat-rpm/conserver.init conserver-8.1.16-di
    status)
 -    status conserver
 +    $STATUS conserver
++    return $?
      ;;
    restart)
 -    echo -n "Restarting conserver: "

--
Arif Ali

catch me on freenode IRC, username: arif-ali


On 23 May 2013 11:39, Arif Ali <m...@arif-ali.co.uk> wrote:

> Thanks for that Lindsay, The LSB compliance did help, and went through all
> the steps, and the following patch fixed the problem, now that it is LSB
> compliance. I no longer get the errors with crm any more.
>
> # diff -u conserver.orig conserver
> --- conserver.orig    2013-05-20 22:06:03.539936238 +0100
> +++ conserver    2013-05-22 23:01:13.300303362 +0100
> @@ -86,7 +86,7 @@
>      if [ "$?" != "0" ]; then
>          echo -n "conserver not running, not stopping "
>          $PASSED
> -        exit 1
> +        exit 0
>      fi
>      echo -n "Shutting down conserver: "
>      killproc conserver
> @@ -100,6 +100,7 @@
>      ;;
>    status)
>      $STATUS conserver
> +    exit $?
>      ;;
>    restart)
>      $STATUS conserver >& /dev/null
>
>
> --
> Arif Ali
>
> catch me on freenode IRC, username: arif-ali
>
>
> On 22 May 2013 15:57, Lindsay Todd <rltodd....@gmail.com> wrote:
>
>> Arif,
>>
>> I know you did say you made the changes to the conserver script to make
>> it LSB compliant, but can you sanity-check it for compliance:
>> http://clusterlabs.org/doc/en-US/Pacemaker/1.1-crmsh/html/Pacemaker_Explained/ap-lsb.html
>>
>> Maybe you need to increase the timeouts for starting, or stopping, this
>> resource?  (Does it take a while to start, or to start, or to do a status,
>> if you run the script manually?  Your timeouts need to reflect this.)  You
>> are starting it up after xcatd is started?  (I have a resource group with
>> xcatd, my xcathelper script resource, dhcpd, conserver, and httpd, so that
>> everything is treated as a group, colocated, and ordered.  The resource
>> group colocates after an HA-IP address is started.)
>>
>>
>> On Wed, May 22, 2013 at 3:50 AM, Arif Ali <arifa...@gmail.com> wrote:
>>
>>>  Hi Li,
>>>
>>> Let me make it clear, The conserver starts, and works without any
>>> problems, but the crm_mon shows an error (can't really give what that is at
>>> the moment), when failing over, then this is one of the services that then
>>> causes the failover not to work.
>>>
>>> The service conserver on it's own has no problems at all, and I do get
>>> exit status to 0, this was the first thing I checked.
>>>
>>> The error I think was on the following lines when I did "crm status"
>>>
>>> Failed actions:
>>>     xCAT_conserver_stop_0 (node=mg01, call=21, rc=1, status=complete):
>>> unknown error
>>>
>>> I hope that makes sense
>>>
>>> regards,
>>> Arif
>>>
>>>
>>> On 22/05/13 01:44, Guang Cheng Li wrote:
>>>
>>> HI,
>>>
>>> I was not seeing issue with conserver when I setup the HAMN with
>>> DRBD+Pacemaker+Corosync, you mentioned conserver could not be started, if
>>> you try to start it manually, does the command "service conserver start"
>>> returns 0 or not? it is expected to return 0. And what is your Pacemaker
>>> resource definition for conserver?
>>>
>>> Thanks,
>>> -------------------------------------------------------------------------
>>> Li,Guang Cheng (李光成)
>>> IBM China System Technology Laboratory
>>> Address: Building 28, ZhongGuanCun Software Park,
>>>          No.8, Dong Bei Wang West Road, Haidian District Beijing 100193,
>>> PRC
>>>
>>> 北京市海淀区东北旺西路8号中关村软件园28号楼
>>> 邮编: 100193
>>>
>>> [image: Inactive hide details for Lindsay Todd ---2013-05-21
>>> 05:52:00---You have to also make sure that makeconservercf is run before 
>>> c]Lindsay
>>> Todd ---2013-05-21 05:52:00---You have to also make sure that
>>> makeconservercf is run before conserver starts up; other actions are
>>>
>>> From: Lindsay Todd <rltodd....@gmail.com> <rltodd....@gmail.com>
>>> To: xCAT Users Mailing list 
>>> <xcat-user@lists.sourceforge.net><xcat-user@lists.sourceforge.net>
>>> Date: 2013-05-21 05:52
>>> Subject: Re: [xcat-user] XCAT MN HA
>>>  ------------------------------
>>>
>>>
>>>
>>> You have to also make sure that makeconservercf is run before conserver
>>> starts up; other actions are makedhcp and restart sshd.  You have to do
>>> this after xcatd is running.  We put together an "xCAThelper" resource
>>> agent to do these for us.  This has worked out very well for us (especially
>>> when an IPoIB bug was oopsing the MN regularly).
>>>
>>> Hope this helps.
>>>
>>> /Lindsay
>>>
>>>
>>> On Mon, May 20, 2013 at 2:27 PM, Arif Ali 
>>> <*m...@arif-ali.co.uk*<m...@arif-ali.co.uk>>
>>> wrote:
>>>
>>>    Hi team,
>>>
>>>    I am working on getting an image working such that I can do HA
>>>    as described in the docs.
>>>
>>>    The osimage template is almost complete, The main thing that
>>>    is missing from my setup is the conserver not working.
>>>
>>>    I have looked through the docs, and there was a mention of conserver
>>>    not being LSB compatible; I have made the relevant changes, but still
>>>    having some problems. As soon as conserver is removed from the corosync
>>>    configs, it seems all good.
>>>
>>>    I would very much like to hear your experiences, and any other
>>>    gotchas
>>>    --
>>>    Arif Ali
>>>
>>>    catch me on freenode IRC, username: arif-ali
>>>
>>>
>>>    
>>> ------------------------------------------------------------------------------
>>>    AlienVault Unified Security Management (USM) platform delivers
>>>    complete
>>>    security visibility with the essential security capabilities. Easily
>>>    and
>>>    efficiently configure, manage, and operate all of your security
>>>    controls
>>>    from a single console and one unified framework. Download a free
>>>    trial.*
>>>    **http://p.sf.net/sfu/alienvault_d2d*<http://p.sf.net/sfu/alienvault_d2d>
>>>    _______________________________________________
>>>    xCAT-user mailing list*
>>>    **xCAT-user@lists.sourceforge.net* <xCAT-user@lists.sourceforge.net>*
>>>    
>>> **https://lists.sourceforge.net/lists/listinfo/xcat-user*<https://lists.sourceforge.net/lists/listinfo/xcat-user>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> AlienVault Unified Security Management (USM) platform delivers complete
>>> security visibility with the essential security capabilities. Easily and
>>> efficiently configure, manage, and operate all of your security controls
>>> from a single console and one unified framework. Download a free trial.
>>> http://p.sf.net/sfu/alienvault_d2d
>>> _______________________________________________
>>> xCAT-user mailing list
>>> xCAT-user@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/xcat-user
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
>>>
>>>
>>>
>>> _______________________________________________
>>> xCAT-user mailing 
>>> listxCAT-user@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/xcat-user
>>>
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Try New Relic Now & We'll Send You this Cool Shirt
>>> New Relic is the only SaaS-based application performance monitoring
>>> service
>>> that delivers powerful full stack analytics. Optimize and monitor your
>>> browser, app, & servers with just a few lines of code. Try New Relic
>>> and get this awesome Nerd Life shirt!
>>> http://p.sf.net/sfu/newrelic_d2d_may
>>> _______________________________________________
>>> xCAT-user mailing list
>>> xCAT-user@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/xcat-user
>>>
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> Try New Relic Now & We'll Send You this Cool Shirt
>> New Relic is the only SaaS-based application performance monitoring
>> service
>> that delivers powerful full stack analytics. Optimize and monitor your
>> browser, app, & servers with just a few lines of code. Try New Relic
>> and get this awesome Nerd Life shirt!
>> http://p.sf.net/sfu/newrelic_d2d_may
>> _______________________________________________
>> xCAT-user mailing list
>> xCAT-user@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/xcat-user
>>
>>
>
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may
_______________________________________________
xCAT-user mailing list
xCAT-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xcat-user

Reply via email to