Hello Erik,

Another little patch for rescaling.
Maybe I understand rescaling wrong, but I think it can never have worked.
This is how I use it:
I select a label by pressing the middle mouse button and releasing it again.
Then I press Alt-r and a box is drawn. When I move the mouse nothing happens.
Finally the label is rescaled if I press the mouse somewhere.

The drag, that should have been drawing a moving outline box responds to a
ButtonMotionMask.
However since no button is being pressed nothing happens. So in my
understanding, it should have been a
PointerMotionMask instead.

Furthermore the bounding box is not recalculated after a rescale.

Finally added some missing cleanups of handlers for RESCALE_MODE and
SELAREA_MODE for the Xt version.

Check the use where you click on the "move" icon to put it in "move"
mode, then click on an element to start a move---that changes the move
operation from a button-motion to a pointer-motion.

I got a bit concerned that the xlib_drag and xctk_drag functions were
being somewhat randomly called with either ButtonMotionMask or
PointerMotionMask.  Generally speaking, xcircuit treats buttons like
keys and does not distinguish between pointer motion with or without
buttons (the peculiarity of X11 in treating buttons as somehow
fundamentally different from keyboard keys has always annoyed me.
Why have "ButtonMotionMask" but not "KeyMotionMask"?).  Mainly, I was
worried that an event handler registered with PointerMotionMask would
be unregistered with ButtonMotionMask, causing the event to fail to
be unregistered.  So I went through and changed all occurrances to
"ButtonMotionMask | PointerMotionMask" to cover all bases (I'm not
sure if ButtonMotionMask is a subset of PointerMotionMask, haven't
tested that).
                                                ---Tim

+--------------------------------+-------------------------------------+
| Dr. R. Timothy Edwards (Tim)   | email: [email protected]    |
| Open Circuit Design, Inc.      | web:   http://opencircuitdesign.com |
| 22815 Timber Creek Lane        | phone: (301) 528-5030               |
| Clarksburg, MD 20871-4001      | cell:  (240) 401-0616               |
+--------------------------------+-------------------------------------+
_______________________________________________
Xcircuit-dev mailing list
[email protected]
http://www.opencircuitdesign.com/mailman/listinfo/xcircuit-dev

Reply via email to