Yep good idea. But then we must adhere to the Sun java coding conventions.
BTW I am done with the coding conventions and logging refactoring (did some other small refactorings too). Just a decision on the curly braces is needed, and then I can commit my stuff. Mathias ----- Original Message ----- From: "Erik Hatcher" <[EMAIL PROTECTED]> To: "Aslak Helles�y" <[EMAIL PROTECTED]>; "Mathias Bogaert" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Saturday, May 04, 2002 5:22 AM Subject: Re: [Xdoclet-devel] Coding conventions and Logging > Why not follow what Checkstyle (http://checkstyle.sourceforge.net) checks > out of the box?! It uses Sun's coding conventions. In general, Jakarta > follows The Elements of Java Style guidelines. Several Jakarta projects are > now integrating Checkstyle into their build files. > > Erik > > > ----- Original Message ----- > From: "Aslak Helles�y" <[EMAIL PROTECTED]> > To: "Mathias Bogaert" <[EMAIL PROTECTED]>; > <[EMAIL PROTECTED]> > Sent: Saturday, May 04, 2002 7:16 AM > Subject: RE: [Xdoclet-devel] Coding conventions and Logging > > > > 1 and 2) I too would prefer curly braces on the same line, not next line > > (same argument as Mathias - more compact code), but I ain't religious > about > > it. Let's at least use the same convention for all places (class, method, > > loops etc) > > > > 3) This was inserted by the old pretty.settings, and isn't really inserted > > anymore. It's just leftovers. Of course they should be removed, but when > we > > do, lets write some real docs. > > > > Aslak > > > > > -----Original Message----- > > > From: [EMAIL PROTECTED] > > > [mailto:[EMAIL PROTECTED]]On Behalf Of Mathias > > > Bogaert > > > Sent: 4. mai 2002 22:05 > > > To: [EMAIL PROTECTED] > > > Subject: Re: [Xdoclet-devel] Coding conventions and Logging > > > > > > > > > I can live with 1, 3 and the blanks. But 2 makes the source long > > > and IMO it > > > takes more time to read (and these are not the java coding conventions). > > > > > > Mathias > > > > > > ----- Original Message ----- > > > From: "Ara Abrahamian" <[EMAIL PROTECTED]> > > > To: "'Mathias Bogaert'" <[EMAIL PROTECTED]>; > > > <[EMAIL PROTECTED]> > > > Sent: Saturday, May 04, 2002 3:41 AM > > > Subject: RE: [Xdoclet-devel] Coding conventions and Logging > > > > > > > > > > 1. > > > > class blabla > > > > { <-new line > > > > > > > > 2. > > > > public void blabla() > > > > { <-new line > > > > > > > > 3. Remove all those nonsense @todo-javadoc items: > > > > /** > > > > * @todo-javadoc Describe the field > > > > */ > > > > > > > > > > > > > > > > I also like this one but can live w/o it (again blanks before/after): > > > > > > > > public GenerationManager( TemplateSubTask subtask ) <- (blank > > > > blank) > > > > > > > > > > > > Log log = LogUtil.getLog( GenerationManager.class, "xml" ); > > > > > > > > Ara. > > > > > > > > > -----Original Message----- > > > > > From: [EMAIL PROTECTED] > [mailto:xdoclet-devel- > > > > > [EMAIL PROTECTED]] On Behalf Of Mathias Bogaert > > > > > Sent: Saturday, May 04, 2002 11:22 PM > > > > > To: [EMAIL PROTECTED] > > > > > Subject: [Xdoclet-devel] Coding conventions and Logging > > > > > > > > > > Ok guys, > > > > > > > > > > I have attached the new version of the GenerationManager, as an > > > > example of > > > > > what it will look like after the conding conventions and logging > > > > changes. > > > > > Look at it and tell me if you like it or not. > > > > > > > > > > Mathias > > > > > > > > > > > > > > > > _______________________________________________________________ > > > > > > > > Have big pipes? SourceForge.net is looking for download > > > mirrors. We supply > > > > the hardware. You get the recognition. Email Us: > > > [EMAIL PROTECTED] > > > > _______________________________________________ > > > > Xdoclet-devel mailing list > > > > [EMAIL PROTECTED] > > > > https://lists.sourceforge.net/lists/listinfo/xdoclet-devel > > > > > > > > > > > > > _______________________________________________________________ > > > > > > Have big pipes? SourceForge.net is looking for download mirrors. We > supply > > > the hardware. You get the recognition. Email Us: > [EMAIL PROTECTED] > > > _______________________________________________ > > > Xdoclet-devel mailing list > > > [EMAIL PROTECTED] > > > https://lists.sourceforge.net/lists/listinfo/xdoclet-devel > > > > > > _______________________________________________________________ > > > > Have big pipes? SourceForge.net is looking for download mirrors. We supply > > the hardware. You get the recognition. Email Us: [EMAIL PROTECTED] > > _______________________________________________ > > Xdoclet-devel mailing list > > [EMAIL PROTECTED] > > https://lists.sourceforge.net/lists/listinfo/xdoclet-devel > > > > _______________________________________________________________ Have big pipes? SourceForge.net is looking for download mirrors. We supply the hardware. You get the recognition. Email Us: [EMAIL PROTECTED] _______________________________________________ Xdoclet-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
