The following comment has been added to this issue:

     Author: Aslak Helles�y
    Created: Sun, 2 Feb 2003 10:35 AM
       Body:
Answers to your 4 questions:

1) I don't think many people will need this. I don't see why a code generator would 
duplicate code, which AFAICT is what the feature will be used for.

2) Your solution will make it slower. Mine won't, since the only addition is one call 
to a setter to set the AST node for the method. Keep in mind that xjavadoc can be run 
in two modes. With or without AST generation. XDoclet uses the AST - less mode, which 
is faster. You'd need the AST mode, and this would require a switch in the XJavadoc 
Ant task to indicate what mode you want. Call XJavaDoc.setUseNodeParser before parsing 
begins.

3) We'll add your contribution if you implement it as I have described.

4) That's not the correct approach. See my previous comments. Don't change voids to 
Strings.

Hope this makes things a bit clearer.
---------------------------------------------------------------------
View the issue:

  http://opensource.atlassian.com/projects/xdoclet/secure/ViewIssue.jspa?key=XJD-15


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: XJD-15
    Summary: XMethod should have a getBody
       Type: Improvement

     Status: Closed
   Priority: Minor
 Resolution: WON'T FIX

 Time Spent: Unknown
   Estimate: 0 minutes

    Project: XJavaDoc
  Component: Core

   Assignee: xdoclet-devel (Use for new issues)
   Reporter: Luiz-Otavio Zorzella

    Created: Sun, 2 Feb 2003 6:12 AM
    Updated: Sun, 2 Feb 2003 8:57 AM
Environment: All

Description:
XMethod allows to get the tags and method signatures, but not the method body itself. 
This should be added. The usefulness is described in this email of mine to the list:

***********************

getting body methods is useful when dealing with "conversion" getters and setters. For 
example, if my Bean has a method:

public Integer getTempInFahrenheit () {
    return TempUtil.c2f (getTempInCelcius ());
}

(analogously for set). I could have these methods copied "as-is" to a generated Struts 
Form Object or Value Object. This is useful for any conversion: IP (Long vs String), 
date (long vs oh-so-many other ways), measurements, etc...

Any advice to a xjavadoc-dev newbie to add a getBody to XMethod (or elsewhere)? 


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://opensource.atlassian.com/projects/xdoclet/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira



-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
_______________________________________________
xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to