I just refactored the sub tasks in the Hibernate module and added a new one to generate the hibernate.cfg.xml file and ran into a problem. The sub tasks: JBossServiceSubTask, FactoryClassSubTask, and HibernateCfgSubTask all do essentially the same thing. They generate either Java code or XML configuration files which are used to create a
Hibernate SessionFactory. They all take about the same subset of properties. So I thought, great, make a base class with the data
members and getters. The doclet tags that are different go on the derived class setters. XDoclet can walk up inheritance chains to get values.


Having coded it, an exception during build is now occurring in XDocletTagSupport because the base class HibernateBaseSubTask is missing the ant.element XDoclet tag and required properties. It really simplified and trimmed down the code to do this. Would it be acceptable to introduce an ant.element tag attribute and supporting code changes in XDocletTagSupport that could mark and recognize it was not an used task class, but a supporting base task class? If acceptable I was going to send the patch files to an XDoclet committer. Thank you.

As an aside, the DocletContext class method getActiveSubTask(), is that return the main Hibernate task or the most inner sub task? IE: JBossServiceSubTask, FactoryClassSubTask, or HibernateCfgSubTask. Again
thank you.


Fred.





-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
xdoclet-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel

Reply via email to