The following comment has been added to this issue:
Author: Chandrashekara K A
Created: Mon, 31 Jan 2005 2:01 AM
Body:
And there seems to be a missing call to tag.validate(). The calls from
SourceClass do not really reach a validation handler registered.
I fixed it by adding
if(isValidating())
{
tag.validate();
}
to the code in createTag.
Patch attached (as patch.diff - has diffs addressed in the description of the
"imporvement".)
---------------------------------------------------------------------
View this comment:
http://opensource.atlassian.com/projects/xdoclet/browse/XJD-55?page=comments#action_15805
---------------------------------------------------------------------
View the issue:
http://opensource.atlassian.com/projects/xdoclet/browse/XJD-55
Here is an overview of the issue:
---------------------------------------------------------------------
Key: XJD-55
Summary: Unnecessary "thorw" in validating mode
Type: Improvement
Status: Open
Priority: Minor
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: XJavaDoc
Components:
Core
Versions:
1.1
Assignee: xdoclet-devel (Use for new issues)
Reporter: Chandrashekara K A
Created: Mon, 31 Jan 2005 1:03 AM
Updated: Mon, 31 Jan 2005 2:01 AM
Environment: All
Description:
XTagFactory.createTag method raises an exception when the tagClass is null for
the current tag.
It does it at the end of the method.
One of the following will be an improvement
1/ Set the tagClass to "DefaultXTag.class" and do away with the code that
raises the exception - as the rest of the code instantiates a DefaultXTag when
tagClass is null.
2/ validate early and raise the exception before everything else
Teh attached patch implements 1.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/xdoclet/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
xdoclet-devel mailing list
xdoclet-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xdoclet-devel
