Hi Anil ;-) Thanks for your patch! However, sexpr.ml aims to be the public interface for that library so it would be better to rename SExpr.ml into sexpr_internals.ml or something similar instead. And ideally, it would be even better to have a proper library interface to hide these details to the outside.
So, would it be possible for you to resend a new patch doing that renaming than we could apply? Cheers, Thomas From: [email protected] [mailto:[email protected]] On Behalf Of Anil Madhavapeddy Sent: 04 November 2009 13:19 To: Dave Scott Cc: [email protected] Subject: Re: [Xen-API] release of 'xapi' toolstack On 3 Nov 2009, at 15:30, Dave Scott wrote: http://xenbits.xen.org/xapi/xen-api-libs.hg -- internal libraries (e.g. for talking to xenstore) This repository fails to checkout at all on MacOS X due to a case-sensitivity conflict with sexpr/s{E|e}xpr.ml. Patch attached to rename the thread-safe string conversion module to sexpr_marshal instead. http://xenbits.xen.org/xapi/xen-api.hg -- the toolstack itself And a patch attached to rename uses of Sexpr to Sexpr_marshal here as well. Not compile tested as I dont have a dev environment for Xapi here yet. -anil
_______________________________________________ xen-api mailing list [email protected] http://lists.xensource.com/mailman/listinfo/xen-api
