On Mon, 2014-11-10 at 10:29 -0500, Meng Xu wrote: > I'm not sure if I should resend the patch just to change the commit > log and add the reason of why doing this. > Yes, that is usually quite a good reason, as changelogs are really important (for the reasons George pointed out already).
Sometimes, maintainers and committers do the edits themselves (after asking or at least informing the mailing list), but this only happens for minor and not substantial modifications. In this case, the most correct thing is that you resend. > George, if I should resend the patch set, please let me know. > I'm not George but, yes, please, do resend. :-) Thanks and Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel