>>> On 11.11.14 at 10:35, <tiejun.c...@intel.com> wrote: >> Have a structure field named e.g. "flags" and a #define consuming >> exactly one bit of it. Just like it's being done everywhere else. > > Like this? > > typedef struct xen_domctl_assign_device xen_domctl_assign_device_t; > DEFINE_XEN_GUEST_HANDLE(xen_domctl_assign_device_t); > > +struct xen_guest_pcidev_info { > + uint8_t bus; > + uint8_t devfn; > + struct { > + uint32_t force : 1, > + reserved : 31; > + }flags; > +};
I said #define for a reason - with a few exceptions we try to avoid using bit fields in the public interface. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel