Hi,

I git clone nova-juno from github and searched for 'pygrub'. Here is what i
get.

.//etc/nova/rootwrap.d/compute.filters:104:# nova/virt/xenapi/vm_utils.py:
'pygrub', '-qn', dev_path
.//etc/nova/rootwrap.d/compute.filters:105:pygrub: CommandFilter, pygrub,
root
.//nova/tests/unit/virt/xenapi/test_xenapi.py:667:
 self.assertEqual(self.vm['PV_bootloader'], 'pygrub')
.//nova/virt/xenapi/vm_utils.py:298:            rec['PV_bootloader'] =
'pygrub'

It seems that nova does not specify absolute path for pygrub.

I checked libvirt source code and found the following definition.

.//src/libxl/libxl_conf.h:52:# define LIBXL_BOOTLOADER_PATH BINDIR "/pygrub"

Searched further for difinition of BINDIR revealed the followings.

Xing:libvirt-1.2.2 xing$ grep BINDIR -Rn ./
.//ChangeLog:48645:  SBINDIR "/libvirtd"
.//ChangeLog:48646:  SBINDIR "/libvirtd_dbg"
.//build-aux/ltmain.sh:2408:  -bindir BINDIR    specify path to binaries
directory (for systems where
.//gnulib/lib/Makefile.in:2499:  echo '#define BINDIR "$(bindir)"'; \
.//gnulib/lib/Makefile.in:2500:  echo '#define SBINDIR "$(sbindir)"'; \
.//gnulib/lib/gnulib.mk:303:  echo '#define BINDIR "$(bindir)"'; \
.//gnulib/lib/gnulib.mk:304:  echo '#define SBINDIR "$(sbindir)"'; \

I guess BINDIR was pointed to /usr/bin.

-Xing

On Thu, Nov 20, 2014 at 2:30 AM, Ian Campbell <ian.campb...@citrix.com>
wrote:

> On Wed, 2014-11-19 at 11:57 -0700, Xing Lin wrote:
> > Hi Ian,
> >
> >
> > Both of your two points are valid. There is no need to install
> > virt-manager. And the patch to start a qemu process in /etc/init.d/xen
> > seems to be enough for launching instances from horizon. I have
> > updated the wiki page.  Please review it at
> >
> > http://wiki.xenproject.org/wiki/Xen_via_libvirt_for_OpenStack_juno
>
> Looks much better, thanks!
>
> I think the need to symlink pygrub to /usr/bin should be considered an
> openstack bug. I presume nova specifies the absolute path, when it
> should just say "pygrub" by default and let the toolstack find the
> default one.
>
> Ian.
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Reply via email to