On Mon, Dec 01, 2014 at 02:50:56PM +0000, Ian Campbell wrote:
> On Mon, 2014-12-01 at 14:27 +0000, Euan Harris wrote:
> > libxl__domain_rename() unconditionally dereferences its new_name
> > parameter, to check whether it is an empty string. Add a check to
> > avoid a segfault if new_name is null.
> >
> > Signed-off-by: Euan Harris <euan.har...@citrix.com>
>
> Acked-by: Ian Campbell <ian.campb...@citrix.com>
>
> I think this is a good fix to have for 4.5, Konrad CCd.
Release-Acked-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
>
> > ---
> > tools/libxl/libxl.c | 7 +++++++
> > 1 files changed, 7 insertions(+), 0 deletions(-)
> >
> > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > index f84f7c2..6e84b5d 100644
> > --- a/tools/libxl/libxl.c
> > +++ b/tools/libxl/libxl.c
> > @@ -385,6 +385,13 @@ int libxl__domain_rename(libxl__gc *gc, uint32_t domid,
> > }
> > }
> >
> > + if (!new_name) {
> > + LIBXL__LOG(ctx, LIBXL__LOG_ERROR,
> > + "new domain name not specified");
> > + rc = ERROR_INVAL;
> > + goto x_rc;
> > + }
> > +
> > if (new_name[0]) {
> > /* nonempty names must be unique */
> > uint32_t domid_e;
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
