On 09/12/14 14:27, Ian Campbell wrote: > On Fri, 2014-11-28 at 11:37 +0000, Ian Campbell wrote: >> On Thu, 2014-11-27 at 12:34 +0000, Andrew Cooper wrote: >>> The error handling from a failed memory allocation should return >>> PyErr_SetFromErrno(xc_error_obj); rather than simply calling it and >>> continuing >>> to the memcpy() below, with the dest pointer being NULL. >>> >>> Furthermore, the context string is simply an input parameter to the >>> hypercall, >>> and is not mutated anywhere along the way. The error handling elsewhere in >>> the function can be simplified by not duplicating it to start with. >>> >>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >>> Coverity-IDs: 1055305 1055721 >>> CC: Ian Campbell <ian.campb...@citrix.com> >>> CC: Ian Jackson <ian.jack...@eu.citrix.com> >>> CC: Wei Liu <wei.l...@citrix.com> >>> CC: Xen Coverity Team <cover...@xen.org> >> Acked-by: Ian Campbell <ian.campb...@citrix.com> >> >> This would have been far more obviously correct for 4.5 if you had stuck >> to fixing the issue in the first paragraph. > Konrad, given > http://article.gmane.org/gmane.comp.emulators.xen.devel/224881 does this > have a release ack? > > Ian. >
I can resubmit with a clearer description if that would help clarity, but the code is correct for the fixes (not fantastically well) described. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
