On Mon, 2015-01-05 at 10:33 -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 05, 2015 at 02:19:58PM +0000, Andrew Cooper wrote: > > libxl_dominfo contains a ssid_label pointer which will have memory allocated > > for it in libxl_domain_info() if the hypervisor has CONFIG_XSM compiled. > > However, the lack of appropriate use of libxl_dominfo_{init,dispose}() will > > cause the label string to be leaked, even in success cases. > > > > This was discovered by XenServers Coverity scanning, and are issues not > > identified by upstream Coverity Scan. > > > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > > CC: Ian Campbell <ian.campb...@citrix.com> > > CC: Ian Jackson <ian.jack...@eu.citrix.com> > > CC: Wei Liu <wei.l...@citrix.com> > > CC: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > > > > --- > > > > Requesting a release-exception as suggested by IanJ. These are memory leaks > > which accumulate via the successful completion of libxl library functions > > (if > > XSM is enabled), which will undoubtedly cause issues for the likes of > > libvirt > > and xenopsd-libxl which use libxl in daemon processes. > > Release-Acked-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>
Somehow I don't seem to have the original in any folder, I probably fat fingered the D key at some point. Anyway, this looks good to me for 4.5: Acked-by: Ian Campbell <ian.campb...@citrix.com> Applied. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel