> -----Original Message----- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: Wednesday, January 07, 2015 12:52 AM > To: Pang, LongtaoX > Cc: Wei Liu; xen-devel@lists.xen.org; ian.jack...@eu.citrix.com; > ian.campb...@citrix.com; Hu, Robert; Zheng, Di > Subject: Re: [OSSTEST PATCH 3/4] Add nested testcase of installing L2 guest VM > > On Tue, Jan 06, 2015 at 03:28:43AM +0000, Pang, LongtaoX wrote: > > > > > > > -----Original Message----- > > > From: Wei Liu [mailto:wei.l...@citrix.com] > > > Sent: Thursday, December 11, 2014 7:44 PM > > > To: Pang, LongtaoX > > > Cc: xen-devel@lists.xen.org; ian.jack...@eu.citrix.com; > > > ian.campb...@citrix.com; wei.l...@citrix.com; Hu, Robert; Zheng, Di > > > Subject: Re: [OSSTEST PATCH 3/4] Add nested testcase of installing > > > L2 guest VM > > > > > > On Wed, Dec 10, 2014 at 04:07:39PM +0800, longtao.pang wrote: > > > > From: "longtao.pang" <longtaox.p...@intel.com> > > > > > > > > This patch is used for installing L2 guest VM inside L1 guest VM. > > > > > > > > --- > > > > sg-run-job | 2 + > > > > ts-debian-install | 166 > > > > +++++++++++++++++++++++++++++++++++++++++------------ > > > > 2 files changed, 132 insertions(+), 36 deletions(-) > > > > > > > > diff --git a/sg-run-job b/sg-run-job index e513bd1..85f7b22 100755 > > > > --- a/sg-run-job > > > > +++ b/sg-run-job > > > > @@ -292,6 +292,8 @@ proc need-hosts/test-nested {} {return host} > > > > proc run-job/test-nested {} { > > > > run-ts . = ts-debian-hvm-install + host + nested + nested_L1 > > > > run-ts . = ts-xen-install + host + nested + nested_build > > > > + run-ts . = ts-debian-install + host + nested + amd64 + nested_L2 > > > > + run-ts . = ts-guest-destroy + host nested > > > > > > It would also be possible to run ts-debian-hvm-install as L2. That > > > would suite this test case better -- it's testing nested HVM. > > > > > > There's no need to remove the PV test case though. > > > > [Pang, LongtaoX] > > [Pang, LongtaoX] Thanks for checking. We used ts-debian-hvm-install > > for installing L1 HVM guest via ISO Image, because we will build XEN, > XEN-Tools and dom0 kernel inside it, and then we will install L2 guest inside > L1. > > But, L2 guest is just a native OS, so we think use ts-debian-install is > > enough > for installing L2 and will make it easy to control. > > > > ts-debian-install installs a L2 PV guest, which should work even without > nested > HVM enabled for your L1 HVM guest. You're testing nested HVM I think it > makes more sense to install a L2 HVM guest. > [Pang, LongtaoX] Thanks Wei, I will try to re-use the script of ts-debian-hvm-install as L2, maybe it will make this script become complicated. If it works, there will not be necessary to modify and use ts-debian-install anymore. > [...] > > > > +sub start () { > > > > + my $cfg_xend= "/etc/xen/$guesthost.cfg"; > > > > + my $cmd= toolstack()->{Command}." create ".$cfg_xend; > > > > + target_cmd_root($ho, $cmd, 30); > > > > + my $domains = target_cmd_output_root($ho, > > > toolstack()->{Command}." list"); > > > > + logm("guest state is\n$domains"); } > > > > > > I think we already have a guest start script? > > > > > > This hunk is going to break easily if we're more flexible about the > > > toolstack (we already have a partially working libvirt test case). > > > > > > > [Pang, LongtaoX] Thanks for checking, I have tried to use > > ts-guest-start to start guest, but it maybe not suit for here, because some > function and parameters in the script is not necessary here, If we use the > script > we will modify it again and may impact other test jobs. > > So I create a function here to start L2 guest. > > > > Then you need to keep an eye on the ongoing work from Ian Campbell to > factor out abstraction layer of toolstack and rebase accordingly. > > Wei.
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel