On 12/01/15 16:56, Ian Campbell wrote: > On Mon, 2015-01-12 at 15:43 +0000, David Vrabel wrote: >> From: Jenny Herbert <jenny.herb...@citrix.com> >> >> Use the foreign page flag in netback to get the domid and grant ref >> needed for the grant copy. This signficiantly simplifies the netback >> code and makes netback work with foreign pages from other backends >> (e.g., blkback). >> >> This allows blkback to use iSCSI disks provided by domUs running on >> the same host. >> >> Signed-off-by: Jenny Herbert <jennifer.herb...@citrix.com> >> Signed-off-by: David Vrabel <david.vra...@citrix.com> > > I acked v1, has this version changed significantly enough to warrant a > re-review? (Does seem so on first glance)
The important change is: v1: + if (PageForeign(page)) { + get_page_grant_ref(page, ©_gop->source.domid, + ©_gop->source.u.ref); v2: + struct xen_page_foreign *foreign; ... + foreign = xen_page_foreign(page); + if (foreign) { + copy_gop->source.domid = foreign->domid; + copy_gop->source.u.ref = foreign->gref; David _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel