Hi all. Let me explain.
The Renesas R-Car Gen2 is a family of SoCs (R-Car H2, M2, etc.). The "Lager" is a name of development board based on R-Car H2 SoC. The UART IP block named SCIF (Serial Communication Interface with FIFO) is common for all SoCs in R-Car Gen2 family. On Fri, Jan 16, 2015 at 3:08 PM, Ian Campbell <ian.campb...@citrix.com> wrote: > On Fri, 2015-01-16 at 13:05 +0000, Julien Grall wrote: > > Hello Iurii, > > > > Thanks for adding the support of a new board in Xen. > > > > On 16/01/15 12:50, Iurii Konovalenko wrote: > > > diff --git a/xen/include/asm-arm/rcar2-uart.h > b/xen/include/asm-arm/rcar2-uart.h > > > new file mode 100644 > > > index 0000000..10a56fb > > > --- /dev/null > > > +++ b/xen/include/asm-arm/rcar2-uart.h > > > > [..] > > > > > +#ifndef __ASM_ARM_RCAR2_H > > > +#define __ASM_ARM_RCAR2_H > > > > According to the name of the guard should be called > __ASM_ARM_RCAR2_UART_H > > Is RCAR2 the name of the board, the soc or the name of uart IP block? > > I'd prefer the naming (here and for the main driver) to be as far to the > right of that list as possible. > > Ian. > > -- Oleksandr Tyshchenko | Embedded Dev GlobalLogic www.globallogic.com <http://www.globallogic.com/>
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
