>>> On 20.01.15 at 15:37, <julien.gr...@linaro.org> wrote:
> On 20/01/15 09:34, Jan Beulich wrote:
>>>>> On 13.01.15 at 15:25, <julien.gr...@linaro.org> wrote:
>>> --- a/xen/drivers/passthrough/iommu.c
>>> +++ b/xen/drivers/passthrough/iommu.c
>>> @@ -337,6 +337,13 @@ int iommu_do_domctl(
>>> ret = iommu_do_pci_domctl(domctl, d, u_domctl);
>>> #endif
>>>
>>> + if ( ret != -ENOSYS )
>>> + return ret;
>>> +
>>> +#ifdef HAS_DEVICE_TREE
>>> + ret = iommu_do_dt_domctl(domctl, d, u_domctl);
>>> +#endif
>>
>> Please move the (inverted) if() into the #ifdef block (but also see
>> below regarding the specific error code used).
>
> What do you mean by the "inverted if()"?
#ifdef HAS_DEVICE_TREE
if ( ret == -ENOSYS )
ret = iommu_do_dt_domctl(domctl, d, u_domctl);
#endif
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
