On Fri, Jan 30, 2015 at 5:52 PM, Julien Grall <julien.gr...@linaro.org> wrote: > Hi Oleksandr, Hi Julien
> > On 30/01/15 15:38, Oleksandr Tyshchenko wrote: >> For example, such a simple thing as a formula for calculating divider >> value for uart baudrate can differs from one family to >> another despite the fact that these families use the same UART IP >> block named SCIF (clock may be differs - ext/int, another freq). >> Or FIFO size, etc. > > IHMO this look more configuration than logic change in the UART driver. > We don't ask you to support all the configuration of the UART right now > ;). However, if someone comes with a new platform using the SCIF, I > expect him to reuse and fix this driver rather than creating a new one. > > FWIW, the compatible string is "renesas,scif" not rcar smth. So, SCIF > sounds a better name for this UART. ok Just to clarify: - Should I remove all references to "R-Car Gen2" from UART stuff? - Can I keep your "Reviewed-by" after there mechanical changes. It would be nice to hear your and Ian's opinions about board file. > > Regards, > > -- > Julien Grall -- Oleksandr Tyshchenko | Embedded Dev GlobalLogic www.globallogic.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
