On Wed, 4 Feb 2015, parth.di...@linaro.org wrote: > From: Naresh Bhat <naresh.b...@linaro.org> > > Add Generic Interrupt and Distributor (ACPI 5.0) structure. > > Signed-off-by: Naresh Bhat <naresh.b...@linaro.org> > --- > xen/include/acpi/actbl1.h | 29 ++++++++++++++++++++++++++++- > 1 file changed, 28 insertions(+), 1 deletion(-) > > diff --git a/xen/include/acpi/actbl1.h b/xen/include/acpi/actbl1.h > index 9311e3a..dd6dc27 100644 > --- a/xen/include/acpi/actbl1.h > +++ b/xen/include/acpi/actbl1.h > @@ -639,7 +639,9 @@ enum acpi_madt_type { > ACPI_MADT_TYPE_INTERRUPT_SOURCE = 8, > ACPI_MADT_TYPE_LOCAL_X2APIC = 9, > ACPI_MADT_TYPE_LOCAL_X2APIC_NMI = 10, > - ACPI_MADT_TYPE_RESERVED = 11 /* 11 and greater are reserved */ > + ACPI_MADT_TYPE_GENERIC_INTERRUPT = 11, > + ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR = 12, > + ACPI_MADT_TYPE_RESERVED = 13 /* 13 and greater are reserved */
You might as well define the GICv2m and GICR types > }; > > /* > @@ -760,6 +762,31 @@ struct acpi_madt_local_x2apic_nmi { > u8 reserved[3]; > }; > > +/* 11: Generic Interrupt (ACPI 5.0) */ Why not use the 5.1 struct? > +struct acpi_madt_generic_interrupt { acpi_madt_gicc? > + struct acpi_subtable_header header; > + u16 reserved; /* reserved - must be zero */ > + u32 gic_id; > + u32 uid; > + u32 flags; > + u32 parking_version; > + u32 performance_interrupt; > + u64 parked_address; > + u64 base_address; > +}; > + > +/* 12: Generic Distributor (ACPI 5.0) */ Why not use the most recent version here too? > +struct acpi_madt_generic_distributor { acpi_madt_gicd? > + struct acpi_subtable_header header; > + u16 reserved; /* reserved - must be zero */ > + u32 gic_id; > + u64 base_address; > + u32 global_irq_base; > + u32 reserved2; /* reserved - must be zero */ > +}; > + > /* > * Common flags fields for MADT subtables > */ > -- > 1.9.1 > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel